Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MNTR crashing because it is using PolyFill extension method #6768

Merged
merged 3 commits into from
May 18, 2023
Merged

Fix MNTR crashing because it is using PolyFill extension method #6768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78b0742
Revert "Make `HandleActorTaskSchedulerMessage` method `protected virt…
Arkatufus May 17, 2023
1c7f4b4
Fix MNTR crashing because it is using PolyFill extension method
Arkatufus May 17, 2023
70c1b5a
Merge branch 'dev' into fix_MNTR
Arkatufus May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/Akka.Remote.TestKit/CommandLine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static void Initialize(string[] args)
var fixedArgs = new List<string>();
for (var i = 1; i < args.Length - 1; ++i)
{
if (args[i].Equals("-Dmultinode") && args[i + 1].StartsWith('.'))
if (args[i].Equals("-Dmultinode") && args[i + 1].StartsWith("."))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from a char to a string does the trick here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the char variant is a polyfill extension method, the string variant is the String class pure method

{
fixedArgs.Add(args[i] + args[i+1]);
++i;
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka/ActorState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,3 +641,4 @@ public Receive GetCurrentBehavior()
}
}
}