Fix query batch size detection failure #505
Merged
+276
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Arkatufus
commented
Jan 8, 2025
| @@ -219,15 +219,15 @@ private Source<EventEnvelope, NotUsed> EventsByPersistenceIdSource( | |||
| timestamp: r.representation.Timestamp, | |||
| tags: r.tags)); | |||
|
|
|||
| private Source<EventEnvelope, NotUsed> CurrentJournalEvents(long offset, long max, MaxOrderingId latestOrdering) | |||
| private Source<EventEnvelope[], NotUsed> CurrentJournalEvents(long offset, long max, MaxOrderingId latestOrdering) | |||
There was a problem hiding this comment.
Instead of using SelectMany and return a list of EventEnvelopes, we use Select and return a list of EventEnvelope[] arrays instead. This list count will be consistently equals to the number of rows we fetched from the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502
An alternate way to #503 for fixing #502
Changes
CurrentJournalEventsto return a stream orEventEnvelopearray, this way we can still count the actual number of rows returned by the database.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):