Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Use GENERATED AS IDENTITY if version is greater than 10 #459

Merged

Conversation

Arkatufus
Copy link
Contributor

Changes

Change journal table ordering column to BigInt Generated Always As Identity

@Arkatufus
Copy link
Contributor Author

Original performance benchmark:

Test PostgreSql Sql CSV Sql TagTable CSV vs Normal Tag Table vs Normal
Persist 368 409 414 11.14% 12.50%
PersistAsync 4455 12662 12722 184.22% 185.57%
PersistAll 1909 13896 13824 627.92% 624.15%
PersistAllAsync 9557 14131 13338 47.86% 39.56%
PersistGroup10 1988 2054 2062 3.32% 3.72%
PersistGroup25 3595 3819 3830 6.23% 6.54%
PersistGroup50 4302 5819 5952 35.26% 38.35%
PersistGroup100 3698 9224 9520 149.43% 157.44%
PersistGroup200 4091 14166 14747 246.27% 260.47%
PersistGroup400 4423 13797 14716 211.94% 232.72%
Recovering 78549 50754 55299 -35.39% -29.60%
RecoveringTwo 37348 41994 42118 12.44% 12.77%
RecoveringFour 52139 50651 50592 -2.85% -2.97%
Recovering8 57855 56184 56232 -2.89% -2.81%

@Arkatufus
Copy link
Contributor Author

This PR performance benchmark:

Test PostgreSql Sql CSV Sql TagTable CSV vs Normal Tag Table vs Normal
Persist 368 417 421 13.32% 14.40%
PersistAsync 4455 14194 14231 218.61% 219.44%
PersistAll 1909 14215 14178 644.63% 642.69%
PersistAllAsync 9557 12611 13883 31.96% 45.27%
PersistGroup10 1988 2052 2096 3.22% 5.43%
PersistGroup25 3595 4050 4189 12.66% 16.52%
PersistGroup50 4302 6205 6231 44.24% 44.84%
PersistGroup100 3698 10025 9976 171.09% 169.77%
PersistGroup200 4091 14676 14883 258.74% 263.80%
PersistGroup400 4423 14703 15071 232.42% 240.74%
Recovering 78549 55444 53014 -29.41% -32.51%
RecoveringTwo 37348 42035 42189 12.55% 12.96%
RecoveringFour 52139 50578 50472 -2.99% -3.20%
Recovering8 57855 56282 56327 -2.72% -2.64%

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) September 9, 2024 21:00
@Aaronontheweb Aaronontheweb merged commit f11d25e into akkadotnet:dev Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants