Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33] handle 413 error #43

Closed
wants to merge 4 commits into from
Closed

[#33] handle 413 error #43

wants to merge 4 commits into from

Conversation

jorgesosa
Copy link

This solves #33 by processing API responses and making sure they are JSON. When an HTML response is encountered, the code builds a standard response and populates the title and httpStatus with the appropriate values, leaving everything else empty.

@dshafik can you review? Thanks!

Jorge Sosa added 4 commits March 15, 2018 08:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Solving #33 by processing HTML
requests and building a standard JSON
response body
StatusMessage will go away in HTTP/2
so I added a default value of an empty string
in that case
@jorgesosa
Copy link
Author

@dshafik this also fixes #26

@majakubiec
Copy link

majakubiec commented Jan 9, 2023

Hi @jorgesosa,

Thank you for creating the PR. It's been some time since it got created, and since then we migrated to axios and therefore it's no longer working.

I believe there might be easier fix for this issue, so I will to close this issue and take it from here.

Best Regards

@majakubiec majakubiec closed this Jan 9, 2023
@jorgesosa jorgesosa deleted the 33-handle-413-error branch January 9, 2023 14:32
@jorgesosa
Copy link
Author

Thanks @majakubiec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants