🪟🔧 Fix node version on CI (#20287)

* Fix node version on CI * Use lts/gallium * Restore setup-node actions where needed * Package-lock changes * Regenerate package-lock.json
airbytehq · Dec 12, 2022 · bec8ef2 · bec8ef2
1 parent a3708eb
commit bec8ef2
Show file tree

Hide file tree

Showing 16 changed files with 20 additions and 38 deletions.
diff --git a/.github/actions/build-branch/action.yml b/.github/actions/build-branch/action.yml
@@ -27,7 +27,7 @@ runs:
 
     - uses: actions/setup-node@v3
       with:
-        node-version: "lts/gallium"
+        node-version: "lts/*"
 
     - uses: actions/setup-python@v4
       with:

diff --git a/.github/workflows/fe-validate-links.yml b/.github/workflows/fe-validate-links.yml
@@ -19,10 +19,6 @@ jobs:
           distribution: "zulu"
           java-version: "17"
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "lts/gallium"
-
       - name: Set up CI Gradle Properties
         run: |
           mkdir -p ~/.gradle/

diff --git a/.github/workflows/gke-kube-test-command.yml b/.github/workflows/gke-kube-test-command.yml
@@ -72,7 +72,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: "lts/gallium"
+          node-version: "lts/*"
 
       - name: Fix EC-2 Runner
         run: |

diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -218,7 +218,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: "lts/gallium"
+          node-version: "lts/*"
 
       - uses: actions/setup-python@v4
         with:
@@ -397,10 +397,6 @@ jobs:
           distribution: "zulu"
           java-version: "17"
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "lts/gallium"
-
       - uses: actions/setup-python@v4
         with:
           python-version: "3.9"
@@ -456,10 +452,6 @@ jobs:
           distribution: "zulu"
           java-version: "17"
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "lts/gallium"
-
       - uses: actions/setup-python@v4
         with:
           python-version: "3.9"
@@ -587,7 +579,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: "lts/gallium"
+          node-version: "lts/*"
 
       - name: Set up CI Gradle Properties
         run: |
@@ -810,10 +802,6 @@ jobs:
           distribution: "zulu"
           java-version: "17"
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "lts/gallium"
-
       - uses: actions/setup-python@v4
         with:
           python-version: "3.9"
@@ -1058,10 +1046,6 @@ jobs:
         with:
           java-version: "17"
 
-      - uses: actions/setup-node@v2
-        with:
-          node-version: "lts/gallium"
-
       - name: Install unzip
         shell: bash
         run: sudo apt-get update && sudo apt-get install -y unzip

diff --git a/.github/workflows/release-airbyte-os.yml b/.github/workflows/release-airbyte-os.yml
@@ -52,7 +52,8 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: "lts/gallium"
+          node-version: "lts/*"
+
       # necessary to install pip
       - uses: actions/setup-python@v4
         with:
@@ -83,9 +84,6 @@ jobs:
           distribution: "zulu"
           java-version: "17"
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "lts/gallium"
       - uses: actions/setup-python@v4
         with:
           python-version: "3.9"

diff --git a/.github/workflows/run-performance-test.yml b/.github/workflows/run-performance-test.yml
@@ -51,10 +51,6 @@ jobs:
           distribution: "zulu"
           java-version: "14"
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "lts/gallium"
-
       - name: Build
         id: run-specific-test
         run: ./gradlew allTest --tests *${{ github.event.inputs.test-name }}
diff --git a/airbyte-webapp-e2e-tests/.gitignore b/airbyte-webapp-e2e-tests/.gitignore
@@ -23,7 +23,6 @@ yarn-error.log*
 *.iml
 /.idea
 
-.npmrc
 .env
 .env.development
 .env.production

diff --git a/airbyte-webapp-e2e-tests/.npmrc b/airbyte-webapp-e2e-tests/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
diff --git a/airbyte-webapp-e2e-tests/.nvmrc b/airbyte-webapp-e2e-tests/.nvmrc
@@ -0,0 +1 @@
+16.18.1
diff --git a/airbyte-webapp-e2e-tests/build.gradle b/airbyte-webapp-e2e-tests/build.gradle
@@ -3,7 +3,7 @@ plugins {
     id "com.github.node-gradle.node" version "3.3.0"
 }
 
-def nodeVersion = System.getenv('NODE_VERSION') ?: '16.15.1'
+def nodeVersion = new File("${projectDir}/.nvmrc").text.trim();
 
 node {
     download = true

diff --git a/airbyte-webapp-e2e-tests/package-lock.json b/airbyte-webapp-e2e-tests/package-lock.json
diff --git a/airbyte-webapp-e2e-tests/package.json b/airbyte-webapp-e2e-tests/package.json
@@ -2,6 +2,9 @@
   "name": "airbyte-webapp-e2e-tests",
   "version": "0.0.0",
   "description": "Airbyte e2e testing",
+  "engines": {
+    "node": "16.18.1"
+  },
   "scripts": {
     "cypress:open": "cypress open",
     "cypress:ci": "CYPRESS_BASE_URL=http://localhost:8000 cypress run",

diff --git a/airbyte-webapp/.nvmrc b/airbyte-webapp/.nvmrc
@@ -1 +1 @@
-lts/gallium
+16.18.1
diff --git a/airbyte-webapp/build.gradle b/airbyte-webapp/build.gradle
@@ -3,7 +3,8 @@ plugins {
     id "com.github.node-gradle.node" version "3.3.0"
 }
 
-def nodeVersion = System.getenv('NODE_VERSION') ?: '16.15.1'
+// Use the node version that's defined in the .nvmrc file
+def nodeVersion = new File("${projectDir}/.nvmrc").text.trim();
 
 // This array should contain a path to all configs that are common to most build tasks and
 // might affect them (i.e. if any of those files change we want to rerun most tasks)

diff --git a/airbyte-webapp/package-lock.json b/airbyte-webapp/package-lock.json
diff --git a/airbyte-webapp/package.json b/airbyte-webapp/package.json
@@ -3,7 +3,7 @@
   "version": "0.40.25",
   "private": true,
   "engines": {
-    "node": ">=16.0.0"
+    "node": "16.18.1"
   },
   "scripts": {
     "prepare": "cd .. && husky install airbyte-webapp/.husky",