Sort static methods above constructor for React #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it makes more sense to put static methods above the constructor in classes. I would like to update the ESLint configuration to match this, but it looks like the react/sort-comp rule does not support it quite yet. jsx-eslint/eslint-plugin-react#128
|
LGTM |
ljharb
added a commit
that referenced
this pull request
Feb 4, 2016
[guide] [react] Sort static methods above constructor
lencioni
added a commit
to lencioni/react-codemod
that referenced
this pull request
Feb 26, 2016
The Airbnb JavaScript style guide was recently updated to sort static methods to the tops of classes [0]. Since this codemod is designed to follow the constraints of the Airbnb style guide, I figured it would be good to update this as well. [0]: airbnb/javascript#715
lencioni
added a commit
to lencioni/react-codemod
that referenced
this pull request
Feb 26, 2016
The Airbnb JavaScript style guide was recently updated to sort static methods to the tops of classes [0]. Since this codemod is designed to follow the constraints of the Airbnb style guide, I figured it would be good to update this as well. [0]: airbnb/javascript#715
superbuddyy
pushed a commit
to superbuddyy/react-codemod
that referenced
this pull request
Aug 9, 2022
The Airbnb JavaScript style guide was recently updated to sort static methods to the tops of classes [0]. Since this codemod is designed to follow the constraints of the Airbnb style guide, I figured it would be good to update this as well. [0]: airbnb/javascript#715
cookieranger
pushed a commit
to cookieranger/react-codemod
that referenced
this pull request
Jan 16, 2023
The Airbnb JavaScript style guide was recently updated to sort static methods to the tops of classes [0]. Since this codemod is designed to follow the constraints of the Airbnb style guide, I figured it would be good to update this as well. [0]: airbnb/javascript#715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes more sense to put static methods above the constructor
in classes. I would like to update the ESLint configuration to match
this, but it looks like the react/sort-comp rule does not support it
quite yet.
jsx-eslint/eslint-plugin-react#128