Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 3.10: Add runtime type check for ClientSession timeout param (#8022) #8026

Conversation

igorvoltaic
Copy link
Contributor

Backport to 3.10

What do these changes do?

Add runtime type check for ClientSession timeout param when creating a client.

Are there changes in behavior for the user?

A ValueError is raised when using something other than ClientTimeout in timeout param.

Related issue number

Fixes #8021

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES folder

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 12, 2024
@igorvoltaic igorvoltaic changed the title Add runtime type check for ClientSession timeout param (#8022) ba Backport to 3.10: Add runtime type check for ClientSession timeout param (#8022) Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1700e9d) 97.37% compared to head (d5cd299) 97.37%.
Report is 6 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8026   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         108      108           
  Lines       32735    32760   +25     
  Branches     3894     3896    +2     
=======================================
+ Hits        31876    31901   +25     
  Misses        656      656           
  Partials      203      203           
Flag Coverage Δ
CI-GHA 97.28% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.98% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.49% <100.00%> (+0.01%) ⬆️
OS-macOS 96.79% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.39% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.76% <100.00%> (+<0.01%) ⬆️
Py-3.11.7 96.52% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.36% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.38% <100.00%> (+0.01%) ⬆️
Py-3.9.18 96.75% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.13 ?
Py-pypy7.3.14 96.29% <100.00%> (?)
VM-macos 96.79% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.98% <100.00%> (+<0.01%) ⬆️
VM-windows 94.49% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aiohttp/client.py Outdated Show resolved Hide resolved
@igorvoltaic igorvoltaic force-pushed the patchback/backports/3.10/43f3e23b1c66ad8303fd1333ccb86c2301d07d15/pr-8022 branch 2 times, most recently from 8b424db to 68e7f6f Compare January 12, 2024 18:25
@igorvoltaic igorvoltaic force-pushed the patchback/backports/3.10/43f3e23b1c66ad8303fd1333ccb86c2301d07d15/pr-8022 branch from 0446162 to a82c717 Compare January 12, 2024 18:27
@Dreamsorcerer Dreamsorcerer merged commit af647c3 into aio-libs:3.10 Jan 12, 2024
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants