-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime type check for ClientSession
timeout
param
#8022
Add runtime type check for ClientSession
timeout
param
#8022
Conversation
928193b
to
e0ebed2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8022 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 107 107
Lines 32548 32551 +3
Branches 3790 3793 +3
=======================================
+ Hits 31722 31725 +3
Misses 624 624
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
38537a6
to
7575499
Compare
9b9a76b
to
551effa
Compare
ClientSession
timeout
param types properlyClientSession
timeout
param
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 43f3e23 on top of patchback/backports/3.9/43f3e23b1c66ad8303fd1333ccb86c2301d07d15/pr-8022 Backporting merged PR #8022 into master
🤖 @patchback |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 43f3e23 on top of patchback/backports/3.10/43f3e23b1c66ad8303fd1333ccb86c2301d07d15/pr-8022 Backporting merged PR #8022 into master
🤖 @patchback |
… param (aio-libs#8022) (cherry picked from commit 43f3e23)
What do these changes do?
Handle
ClientSession
timeout
param type properly when creating a client.Are there changes in behavior for the user?
A
ValueError
is raised when using something other thanClientTimeout
intimeout
param.Related issue number
Fixes #8021
Checklist
CONTRIBUTORS.txt
CHANGES
folder