Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check origin if insecure scheme and there are origins to treat as secure, in CookieJar.filter_cookies() #7821

Merged
merged 2 commits into from Nov 12, 2023
Merged

Only check origin if insecure scheme and there are origins to treat as secure, in CookieJar.filter_cookies() #7821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
236dd94
Only check origin if insecure scheme and there are origins to treat a…
Rongronggg9 Nov 12, 2023
3f9ddcd
Update aiohttp/cookiejar.py
Dreamsorcerer Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/7821.feature
View file
Open in desktop
@@ -0,0 +1 @@
Only check origin if insecure scheme and there are origins to treat as secure, in ``CookieJar.filter_cookies()``.
15 changes: 8 additions & 7 deletions aiohttp/cookiejar.py
View file
Open in desktop
Expand Up @@ -253,14 +253,15 @@
# Skip rest of function if no non-expired cookies.
return filtered
hostname = request_url.raw_host or ""
request_origin = URL()
with contextlib.suppress(ValueError):
request_origin = request_url.origin()

is_not_secure = (
request_url.scheme not in ("https", "wss")
and request_origin not in self._treat_as_secure_origin
)
is_not_secure = request_url.scheme not in ("https", "wss")
if is_not_secure and self._treat_as_secure_origin:
# Only check origin if insecure scheme and there are origins to
# treat as secure.
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
request_origin = URL()
Dismissed Show dismissed Hide dismissed
with contextlib.suppress(ValueError):
request_origin = request_url.origin()
is_not_secure = request_origin not in self._treat_as_secure_origin

# Point 2: https://www.rfc-editor.org/rfc/rfc6265.html#section-5.4
for cookie in sorted(self, key=lambda c: len(c["path"])):
Expand Down