[PR #7518/8bd42e74 backport][3.8] Fix GunicornWebWorker max_requests_jitter not work #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
`GunicornWebWorker` use `self.cfg.max_requests` which is not add jitter, from https://github.com/benoitc/gunicorn/blob/master/gunicorn/workers/base.py#L56-L60, the correct way is to use `sef.max_requests` (cherry picked from commit 8bd42e7)
5 tasks
Codecov Report
@@ Coverage Diff @@
## 3.8 #7519 +/- ##
==========================================
- Coverage 97.38% 97.37% -0.01%
==========================================
Files 107 107
Lines 31039 31039
Branches 3937 3937
==========================================
- Hits 30226 30224 -2
- Misses 609 610 +1
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dreamsorcerer
deleted the
patchback/backports/3.8/8bd42e742acc825e8b2f170c04216da3c767f56e/pr-7518
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7518 as merged into master (8bd42e7).
What do these changes do?
GunicornWebWorkeruseself.cfg.max_requestswhich is not add jitter, from https://github.com/benoitc/gunicorn/blob/master/gunicorn/workers/base.py#L56-L60, the correct way is to usesef.max_requestsAre there changes in behavior for the user?
After the PR is merged, the max-requests-jitter parameter of Gunicorn can take effect.
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.