Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GunicornWebWorker max_requests_jitter not work #7518

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Fix GunicornWebWorker max_requests_jitter not work #7518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/7518.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix GunicornWebWorker max_requests_jitter not work
2 changes: 1 addition & 1 deletion aiohttp/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ async def _run(self) -> None:
self.notify()

cnt = server.requests_count
if self.cfg.max_requests and cnt > self.cfg.max_requests:
if self.max_requests and cnt > self.max_requests:
self.alive = False
self.log.info("Max requests, shutting down: %s", self)

Expand Down
4 changes: 2 additions & 2 deletions tests/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ async def test__run_ok_parent_changed(
worker.sockets = [sock]
worker.log = mock.Mock()
worker.loop = loop
worker.max_requests = 0
worker.cfg.access_log_format = ACCEPTABLE_LOG_FORMAT
worker.cfg.max_requests = 0
worker.cfg.is_ssl = False

await worker._run()
Expand All @@ -237,8 +237,8 @@ async def test__run_exc(
worker.sockets = [sock]
worker.log = mock.Mock()
worker.loop = loop
worker.max_requests = 0
worker.cfg.access_log_format = ACCEPTABLE_LOG_FORMAT
worker.cfg.max_requests = 0
worker.cfg.is_ssl = False

def raiser() -> None:
Expand Down