Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7348/bf9d753e backport][3.8] 馃悰 Fix RST in changelog template before links #7349

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jul 8, 2023

This is a backport of PR #7348 as merged into master (bf9d753).

In corner cases, changelog fragments with things like detached link definitions (example: #7346) cause RST rendering errors. This patch corrects this by injecting empty lines between the changelog entry bodies and their reference lists.

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #7349 (dc13820) into 3.8 (9a41831) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.8    #7349      +/-   ##
==========================================
+ Coverage   97.30%   97.39%   +0.08%     
==========================================
  Files         107      107              
  Lines       30996    30996              
  Branches     3243     3924     +681     
==========================================
+ Hits        30161    30188      +27     
+ Misses        625      604      -21     
+ Partials      210      204       -6     
Flag Coverage 螖
CI-GHA 97.25% <酶> (+0.07%) 猬嗭笍
OS-Linux 96.91% <酶> (+0.06%) 猬嗭笍
OS-Windows 95.23% <酶> (+0.39%) 猬嗭笍
OS-macOS 96.64% <酶> (+0.30%) 猬嗭笍
Py-3.10.11 94.84% <酶> (-0.01%) 猬囷笍
Py-3.10.12 96.54% <酶> (+0.05%) 猬嗭笍
Py-3.11.0 96.21% <酶> (?)
Py-3.6.15 96.37% <酶> (+0.04%) 猬嗭笍
Py-3.6.8 94.76% <酶> (?)
Py-3.7.17 96.53% <酶> (酶)
Py-3.7.9 94.89% <酶> (?)
Py-3.8.10 94.82% <酶> (?)
Py-3.8.17 96.44% <酶> (+0.12%) 猬嗭笍
Py-3.9.13 94.81% <酶> (?)
Py-3.9.17 96.50% <酶> (+0.15%) 猬嗭笍
Py-pypy7.3.11 93.95% <酶> (?)
VM-macos-latest 96.64% <酶> (+0.30%) 猬嗭笍
VM-ubuntu-20.04 96.89% <酶> (+0.04%) 猬嗭笍
VM-ubuntu-latest 96.44% <酶> (?)
VM-windows-latest 95.23% <酶> (+0.39%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz enabled auto-merge (squash) July 8, 2023 09:21
@webknjaz webknjaz merged commit a4bf0e8 into 3.8 Jul 8, 2023
34 of 36 checks passed
@webknjaz webknjaz deleted the patchback/backports/3.8/bf9d753edc928e7ecbc590c32603ebd3c1fc6282/pr-7348 branch July 8, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant