Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchback/backports/3.9/ecd9c72697ca1529e7cae4693775612987a2a6d2/pr 6559 #7264

Conversation

rohansahai
Copy link
Contributor

@rohansahai rohansahai commented Apr 29, 2023

What do these changes do?

Backporting following these guidelines - #6559 (comment) so we can get configurable header size limits in the next release

<!-- Thank you for your contribution! -->

Allow the user to set the response header limits. The properties
max_line_size, max_headers and max_field_size can be set on
ClientSession creation. Default values are: `max_line_size=8190`
`max_headers=32768` and `max_field_size=8190`.
Thus the user can set and - when needed - receive bigger response
headers.

No

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."

---------

Co-authored-by: Josef Prenner <josef@cloudomation.com>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit ecd9c72)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 29, 2023
@Dreamsorcerer Dreamsorcerer changed the base branch from master to 3.9 April 29, 2023 12:13
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #7264 (8852c6e) into 3.9 (2b3db3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.9    #7264   +/-   ##
=======================================
  Coverage   97.31%   97.32%           
=======================================
  Files         108      108           
  Lines       31596    31666   +70     
  Branches     4013     4023   +10     
=======================================
+ Hits        30748    30818   +70     
  Misses        641      641           
  Partials      207      207           
Flag Coverage Δ
CI-GHA 97.22% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.89% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.49% <100.00%> (+0.01%) ⬆️
OS-macOS 96.47% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.95% <100.00%> (+<0.01%) ⬆️
Py-3.11.0 96.39% <100.00%> (+<0.01%) ⬆️
Py-3.7.16 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.7.9 94.33% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.27% <100.00%> (+0.01%) ⬆️
Py-3.8.16 96.61% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.27% <100.00%> (+0.01%) ⬆️
Py-3.9.16 96.64% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 94.04% <100.00%> (+0.01%) ⬆️
VM-macos 96.47% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.89% <100.00%> (+<0.01%) ⬆️
VM-windows 94.49% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_proto.py 96.64% <ø> (ø)
aiohttp/client.py 94.86% <100.00%> (+0.06%) ⬆️
tests/test_client_functional.py 98.48% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 94aa627 into aio-libs:3.9 Apr 29, 2023
30 of 32 checks passed
@Dreamsorcerer
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants