Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument to override request body size #6340

Merged
merged 5 commits into from Nov 23, 2021
Merged

Add an argument to override request body size #6340

merged 5 commits into from Nov 23, 2021

Conversation

anesabml
Copy link
Contributor

@anesabml anesabml commented Nov 23, 2021

What do these changes do?

A new argument client_max_size was added to BaseRequest.clone method to allow overriding the request body size.

Are there changes in behavior for the user?

The new argument adds the ability to customize the request body size for each request.

Related issue number

Resolves #5704

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 23, 2021
docs/web_reference.rst Outdated Show resolved Hide resolved
CHANGES/5704.feature Outdated Show resolved Hide resolved
@webknjaz webknjaz added backport-3.8 backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot labels Nov 23, 2021
@webknjaz webknjaz enabled auto-merge (squash) November 23, 2021 22:07
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @anesabml please make sure to oversee the backporting.

@webknjaz webknjaz merged commit f6334e2 into aio-libs:master Nov 23, 2021
@patchback
Copy link
Contributor

patchback bot commented Nov 23, 2021

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply f6334e2 on top of patchback/backports/3.8/f6334e2b4881b9870edcaaa20e9282c4e9dc70f1/pr-6340

Backporting merged PR #6340 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.8/f6334e2b4881b9870edcaaa20e9282c4e9dc70f1/pr-6340 upstream/3.8
  4. Now, cherry-pick PR Add an argument to override request body size #6340 contents into that branch:
    $ git cherry-pick -x f6334e2b4881b9870edcaaa20e9282c4e9dc70f1
    If it'll yell at you with something like fatal: Commit f6334e2b4881b9870edcaaa20e9282c4e9dc70f1 is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x f6334e2b4881b9870edcaaa20e9282c4e9dc70f1
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Add an argument to override request body size #6340 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.8/f6334e2b4881b9870edcaaa20e9282c4e9dc70f1/pr-6340
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Contributor

patchback bot commented Nov 23, 2021

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply f6334e2 on top of patchback/backports/3.9/f6334e2b4881b9870edcaaa20e9282c4e9dc70f1/pr-6340

Backporting merged PR #6340 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.9/f6334e2b4881b9870edcaaa20e9282c4e9dc70f1/pr-6340 upstream/3.9
  4. Now, cherry-pick PR Add an argument to override request body size #6340 contents into that branch:
    $ git cherry-pick -x f6334e2b4881b9870edcaaa20e9282c4e9dc70f1
    If it'll yell at you with something like fatal: Commit f6334e2b4881b9870edcaaa20e9282c4e9dc70f1 is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x f6334e2b4881b9870edcaaa20e9282c4e9dc70f1
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Add an argument to override request body size #6340 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.9/f6334e2b4881b9870edcaaa20e9282c4e9dc70f1/pr-6340
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@anesabml anesabml deleted the client-max-size branch November 24, 2021 07:28
asvetlov pushed a commit that referenced this pull request Dec 4, 2021
…body size (#6340) (#6344)

* Add an argument to override request body size (#6340)

(cherry picked from commit f6334e2)
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customising the maximum size of request payload
3 participants