Logo Update #6306
Merged
Logo Update #6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks @SharanRP . As you can see from the built docs, this isn't sufficient. The current docs are built using pydata-sphinx-theme~=0.13.3, however, support for the new X logo in the fontawesome icon set was added until this PR, which was released with v0.15.0. So you will have to update the pydantic-spinx-theme dependency to this version at least.
|
I have updated the pydata-spinx-theme to 0.15.1 |
GeigerJ2
pushed a commit
to qiaojunfeng/aiida-core
that referenced
this pull request
Apr 10, 2024
Switch to new X branding. This requires an update of the `docs` dependency `pydata-sphinx-theme~=0.15.0` as support for the version of fontawesome that includes the X branding was shipped with that version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #aiidateam/aiida-website#59 (comment)
Twitter logo updated
@eimrek