fix scan iter command issued to different replicas #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
* Streamline client side caching API typing Streamline the typing of the client side caching API. Some of the methods are defining commands of type `str`, while in reality tuples are being sent for those parameters. Add client side cache tests for Sentinels. In order to make this work, fix the sentinel configuration in the docker-compose stack. Add a test for client side caching with a truly custom cache, not just injecting our internal cache structure as custom. Add a test for client side caching where two different types of commands use the same key, to make sure they invalidate each others cached data. * Fixes after running tests against RE * More test cases * Fix async tests * Tests for raw commands * Change terminology for allow/deny lists * Add test for single connection * Make sure flushing the cache works everywhere * Reenable some tests for cluster too * Align cache typings at abstract level * Use Sequence instead of Iterable for types * Remove some exceptions in favor of ifs --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Given that Python 3.10 changed the default list of TLS ciphers, it is a good idea to allow customization of the list of ciphers when using Redis with TLS. In some situations the client is unusable right now with older servers and Python >= 3.10.
Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Issue redis#3154 The CLIENT KILL command has a new option, called MAXAGE, to kill clients older than a given age. Add support for this new option. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
* Support NOVALUES parameter for HSCAN Issue redis#3153 The NOVALUES parameter instructs HSCAN to only return the hash keys, without values. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
agnesnatasya
force-pushed
the
scan-iter-bug
branch
from
11253ba
to
241033d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Ubuntu 22.04,python3.11.2redis.asyncio.sentinelmodule. I wanted to check if the rST syntax is correct, but this module is not included in the builddir's index, so I think it's no-op.fix scan iter command issued to different replicas
Fixes redis#3197