New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix liniting error in pre-commit checks #114
Conversation
Fix formatting from error in pre-commit check
Perhaps is is the forward slash.
Seems it wants parentheses around the dict value.
Going to multiline...
From: killer0071234/python-zamg@419ee04 Added ` # fmt: skip` at the end of the comment line
Is it worth it me looking into the The warning given is:
It may be this need for a further plugin or maybe it is just further test definitions needed to cover 100% of the code.
|
- refer psf/black#4175 - issue identified by jaymunro #114 - bumped pre-commit-hooks repo to v4.5.0
The tests issue requires writing tests for full code coverage. I'm completely without knowledge on the test framework so I suspect I'd need to spend a few hours getting my head around it and learning, and quite possibly more hours learning the special-case workarounds required on top of the general test framework itself. So... yeah :-/ It's something that will probably become more of a priority for me later in the project, especially as it gets more complicated. But for now I'm not going to spend any time on it unless my ADHD suddenly takes an interest 😆 As for the linting.... Well done tracking down the root cause of that issue! From the discussion it looks like isort might become a preferred import-sorting in the longer term. I have a personal issue with a tool that's meant to make code cleaner requiring spraying of directives around. Also, this seems to be due to a bug in reorder-imports maintainer's brain, and he's being a douchebag about it. Since he's betraying the singular stated goal of the tool, I'd rather switch to something else. I've raised a pr at #115 that does this. |
* wip: Trying to get passive updates - nothing functional yet, but since nothing breaks either, committing it for now. - plan is to allow updates to be triggered by incoming advertisements from devices we are maintaining sensors for. * chore: Move from reorder-imports to isort - refer psf/black#4175 - issue identified by jaymunro #114 - bumped pre-commit-hooks repo to v4.5.0 * chore: update black and apply formattings - disabled check on const line because back-and-forth linting conflicts should not take more than three hours to solve. - added black to requirements and bumped to same version in github workflow - gitignore node_modules/.cache for new prettier version.
It seems this may be due to an incompatibility between black and reorder-python-imports
psf/black#4175
I have added the following to the end of the first comment in the files affected:
fmt: skip
Pre-commit is now passing tests
Addresses issue #22