Removing dead code from nacaddr.py. #275
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 91.12% 91.14% +0.01%
==========================================
Files 98 98
Lines 22164 22151 -13
Branches 3320 3319 -1
==========================================
- Hits 20198 20189 -9
+ Misses 1279 1276 -3
+ Partials 687 686 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -516,12 +492,5 @@ def AddressListExclude( | |||
| return sorted(set(ret_array + superset)) | |||
|
|
|||
|
|
|||
| ExcludeAddrs = AddressListExclude | |||
There was a problem hiding this comment.
Seems like third party generators could still be using ExcludeAddrs and Supernet, especially if they looked at code in the built-in generators using them. A deprecation notice seems warranted.
There was a problem hiding this comment.
I should say, a deprecation notice would be warranted and we should not remove ExcludeAddrs and Supernet right away.
Back in when this project was first created Python had no ipaddress library. IIRC Peter Moody created it and open sourced it which is why you will find it copyrighted by Google in https://github.com/python/cpython/blob/main/Lib/ipaddress.py#L1276
You can see there are some slight differences between the one in the "third party" folder and the open source version which is what these deleted lined helped to bridge.
google/capirca@4f694aa
I also deleted a function
_is_subnet_ofthat was necessary while Google was stuck in pre 3.7 but is included at 3.7. We only support 3.7+ so it is safe to remove_is_subnet_of.