PH v1

[BLEMENT33]

Description

I sarted a PH module for the journalism association of ECL.

[codecov]

Codecov Report

Attention: Patch coverage is 91.37931% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 82.74%. Comparing base (44c0634) to head (f9f2b5c).

Files	Patch %	Lines
app/modules/ph/endpoints_ph.py	89.85%	7 Missing ⚠️
app/modules/ph/cruds_ph.py	88.46%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   82.53%   82.74%   +0.20%     
==========================================
  Files          93       97       +4     
  Lines        5962     6078     +116     
==========================================
+ Hits         4921     5029     +108     
- Misses       1041     1049       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[armanddidierjean]

Nice module!

Could you change endpoints to use a lowercase ph? Maybe "newspaper" or "paper" would be better instead of "journal"

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
7298665	Triggered	Generic High Entropy Secret	89a8ace	app/core/auth/schemas_auth.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[guillaumetavernier]

Not much to say ! Nice work !