-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor module visibility to add visibility for new modules #359
base: main
Are you sure you want to change the base?
Conversation
ba40876
to
b0d6e60
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 80.47% 80.27% -0.20%
==========================================
Files 86 86
Lines 5766 5774 +8
==========================================
- Hits 4640 4635 -5
- Misses 1126 1139 +13 ☔ View full report in Codecov by Sentry. |
b0d6e60
to
5bd5752
Compare
5bd5752
to
084e410
Compare
39a549d
to
2a5c4b5
Compare
9d16708
to
e41c3c9
Compare
for new modules
to add new default visibility
e41c3c9
to
7cac715
Compare
from app.api import ( # We need to do it here, because the list is not initialized at startup | ||
module_list, | ||
) | ||
# We need to import the module_list here, because the it is not initialized at startup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# We need to import the module_list here, because the it is not initialized at startup | |
# We need to import the module_list here, because it is not initialized at startup |
root=module.root, | ||
db=db, | ||
) | ||
if module_awareness is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if module_awareness is None: | |
if module_awareness is not None: |
Instead of deleting the ModuleVisibility table, the migration file could add all modules in the table ModuleAwarness because all these modules already use visibility |
Description
With this PR, modules visibility are stored with a column
visible: bool
in db.This allows at startup to add default group ids for new modules, instead of only adding them during the database first initialization
Breaking change: this PR will delete existing Visibilities