Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module/raid registering #347

Draft
wants to merge 233 commits into
base: main
Choose a base branch
from
Draft

Module/raid registering #347

wants to merge 233 commits into from

Conversation

maximeroucher
Copy link
Member

Description

Adding the back end support for the Raid event registration

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

@Petitoto
Copy link
Member

Quick note: please be careful when using get_file_from_data() and save_file_as_data() 😉

Comment says: WARNING: **NEVER** trust user input when calling this function. Always check that parameters are valid.

Currently, your document_id is directly controlled by the user. As it is, it would be a major security flaw.

@maximeroucher
Copy link
Member Author

Yes, this is just a placeholder, the function done are tagged with Tags.raid for now

app/models/models_raid.py Outdated Show resolved Hide resolved
app/cruds/cruds_raid.py Outdated Show resolved Hide resolved
app/endpoints/raid.py Outdated Show resolved Hide resolved
app/endpoints/raid.py Outdated Show resolved Hide resolved
app/endpoints/raid.py Outdated Show resolved Hide resolved
app/models/models_raid.py Outdated Show resolved Hide resolved
app/models/models_raid.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.60%. Comparing base (fba7c78) to head (00a0fd6).
Report is 6 commits behind head on main.

Current head 00a0fd6 differs from pull request most recent head 9340581

Please upload reports for the commit 9340581 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   82.74%   78.60%   -4.15%     
==========================================
  Files          97       79      -18     
  Lines        6081     5440     -641     
==========================================
- Hits         5032     4276     -756     
- Misses       1049     1164     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/modules/raid/cruds_raid.py Outdated Show resolved Hide resolved
app/modules/raid/cruds_raid.py Outdated Show resolved Hide resolved
app/modules/raid/cruds_raid.py Show resolved Hide resolved
app/modules/raid/endpoints_raid.py Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Apr 1, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@maximeroucher maximeroucher force-pushed the module/raid-registering branch 2 times, most recently from a1c32ac to 41e5f82 Compare April 29, 2024 14:03
@maximeroucher maximeroucher force-pushed the module/raid-registering branch 2 times, most recently from ff740a6 to a2e1695 Compare May 4, 2024 09:08
@maximeroucher maximeroucher force-pushed the module/raid-registering branch 2 times, most recently from 3596a99 to bab02e9 Compare May 14, 2024 14:42
@maximeroucher maximeroucher force-pushed the module/raid-registering branch 3 times, most recently from b664ba0 to 2f929c6 Compare May 15, 2024 12:20
@armanddidierjean armanddidierjean force-pushed the module/raid-registering branch 3 times, most recently from 3427e79 to 7c0b04d Compare May 21, 2024 13:26
app/modules/raid/utils/drive/drive_file_manager.py Outdated Show resolved Hide resolved
app/modules/raid/utils/drive/drive_file_manager.py Outdated Show resolved Hide resolved
app/utils/auth/providers.py Outdated Show resolved Hide resolved
app/modules/raid/endpoints_raid.py Outdated Show resolved Hide resolved
app/modules/raid/endpoints_raid.py Outdated Show resolved Hide resolved
app/modules/raid/utils/drive/drive_file_manager.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants