Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert flash-message to Glimmer component #382

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Convert flash-message to Glimmer component #382

merged 5 commits into from
Jun 16, 2022

Conversation

charlesfries
Copy link
Contributor

  • Install @glimmer/component, @glimmer/tracking
  • Convert flash-message component to Glimmer component
  • Use co-located template

RobbieTheWagner
RobbieTheWagner requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this work! The only real change I think we need is moving glimmer to dependencies.

package.json Outdated Show resolved Hide resolved
@RobbieTheWagner
Copy link
Member

@charlesfries I updated a lot of things in the repo. Could you please rebase?

@RobbieTheWagner
Copy link
Member

@charlesfries looks like a template lint error. Not sure why it is showing up all the sudden. Can you add a template-lint-disable comment for that?

@RobbieTheWagner RobbieTheWagner merged commit 0f4c0ac into adopted-ember-addons:master Jun 16, 2022
@RobbieTheWagner
Copy link
Member

Thanks for the PR!

@charlesfries charlesfries deleted the glimmer branch June 20, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlesfries @RobbieTheWagner