Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(component): fix references to missing types upon compiling in tests #951

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

pokedpeter
Copy link
Contributor

@pokedpeter pokedpeter commented Aug 18, 2023

On a fresh develop branch and compiling the Typescript code throws the following errors:
image

Knex is missing type definitions for havingNotNull and orHavingNotNull

Proposed changes

Reference these methods by key like existing entries for orHavingNull and orHavingNotNull which also don't have type definitions.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Sorry, something went wrong.

Knex methods orHavingNull and orHavingNotNull don't have type definitions so don't reference the
methods directly
@RomainLanz RomainLanz merged commit 62ae085 into adonisjs:develop Sep 22, 2023
@RomainLanz
Copy link
Member

Thanks!

@pokedpeter pokedpeter deleted the fix-type-errors-on-compile branch September 22, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants