Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disable-locks flag #932

Merged
merged 1 commit into from
May 22, 2023

Conversation

Reptiluka
Copy link
Contributor

@Reptiluka Reptiluka commented May 20, 2023

Proposed changes

Adding a new command flag to disable locks during migration
As seen in :
planetscale/discussion#307
planetscale/discussion#439
There is some problem with the lock currently with the "new" cloud mysql provider Planetscale

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

As Planetscale provide a safe migration process : https://planetscale.com/docs/concepts/safe-migrations
It could be ok to disable the lock to update the dev branch and then in their dashboard open a migration process to do the migration in production. With that, maybe during their deploy they use some kind of lock under the hood to keep it safe as we wanted.

Also in the Planetscale settings, we could change the Migration table name settings to adonis_schema and when the migration to prod is done, it will copy the row from that table from dev to prod.

As you can see in the Checklist, i didn't do the test because I just don't know how to test my changes. So I tried my best to edit that code to give the idea 🙂

Sorry, something went wrong.

@thetutlage
Copy link
Member

Thanks for the PR. I will take a look at it in some time and see if this is all we need to get it to work with planetscale.

@thetutlage thetutlage merged commit 9bf8f24 into adonisjs:develop May 22, 2023
@thetutlage
Copy link
Member

Looks great. Thanks for the PR

@thetutlage
Copy link
Member

Release as @adonisjs/lucid@18.4.0

@Reptiluka
Copy link
Contributor Author

It's works great, thanks ! 🙂
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants