Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding a new command flag to disable locks during migration
As seen in :
planetscale/discussion#307
planetscale/discussion#439
There is some problem with the lock currently with the "new" cloud mysql provider Planetscale
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
As Planetscale provide a safe migration process : https://planetscale.com/docs/concepts/safe-migrations
It could be ok to disable the lock to update the dev branch and then in their dashboard open a migration process to do the migration in production. With that, maybe during their deploy they use some kind of lock under the hood to keep it safe as we wanted.
Also in the Planetscale settings, we could change the Migration table name settings to adonis_schema and when the migration to prod is done, it will copy the row from that table from dev to prod.
As you can see in the Checklist, i didn't do the test because I just don't know how to test my changes. So I tried my best to edit that code to give the idea 🙂