-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: index-theme system mappings bug [CSS-1114] #3534
Conversation
🦋 Changeset detectedLatest commit: 815545f The changes in this PR will be included in the next version bump. This PR includes changesets to release 83 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -138,7 +138,6 @@ async function main({ | |||
componentName = process.env.NX_TASK_TARGET_PROJECT, | |||
cwd, | |||
} = {}) { | |||
console.log("componentName", componentName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I snuck this fix in - it was a debugging comment I was using earlier and didn't mean for it to go into production.
🚀 Deployed on https://pr-3534--spectrum-css.netlify.app |
File metricsSummaryTotal size: 3.22 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
Description
Fixes a bug in the content of all component's
dist/index-theme.css
file.Expected
index-theme.css
to include the component selectors with component-level custom properties mapped to the--system
prefixed ones in order to allow a component to support various contexts.Expected output example for the index-theme.css:
Broken output:
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn compare
: expect to see major changes to all components'index-theme.css
files as documented above & below. (@cdransf)Screenshots
Note: I did not run VRT on this PR because the
index-theme.css
file is not used.To-do list