Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

Migrate to helix-fetch v2 #361

Merged
merged 15 commits into from
Feb 8, 2021
Merged

Migrate to helix-fetch v2 #361

merged 15 commits into from
Feb 8, 2021

Conversation

stefan-guggisberg
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

@github-actions
Copy link

This PR will trigger a minor release when merged.

@stefan-guggisberg
Copy link
Contributor Author

stefan-guggisberg commented Feb 1, 2021

1 test is still failing:

IFramely not used for other IP addresses - IFramely Tests

I have no clue why. @MarquiseRosier can you please have a look?

@stefan-guggisberg
Copy link
Contributor Author

related: adobe/helix-home#182

@stefan-guggisberg
Copy link
Contributor Author

@MarquiseRosier ping

package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #361 (31da6e9) into main (d01c028) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   97.91%   97.93%   +0.01%     
==========================================
  Files           7        7              
  Lines         240      242       +2     
==========================================
+ Hits          235      237       +2     
  Misses          5        5              
Impacted Files Coverage Δ
src/index.js 96.87% <100.00%> (ø)
src/lottifile.js 100.00% <100.00%> (ø)
src/unsplash.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01c028...31da6e9. Read the comment docs.

@tripodsan tripodsan merged commit 0816b32 into main Feb 8, 2021
@tripodsan tripodsan deleted the helix-fetch-v2 branch February 8, 2021 02:33
@trieloff
Copy link
Contributor

trieloff commented Feb 8, 2021

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants