Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): upgrade to helix-fetch v2 #1624

Merged
merged 3 commits into from Jan 29, 2021
Merged

feat(deps): upgrade to helix-fetch v2 #1624

merged 3 commits into from Jan 29, 2021

Conversation

tripodsan
Copy link
Contributor

No description provided.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@@ -41,7 +41,7 @@
"archiver": "^5.1.0",
"camelcase": "^6.2.0",
"chalk": "4.1.0",
"chokidar": "^3.4.3",
"chokidar": "3.4.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was needed, because I got errors on macOS.
see: fsevents/fsevents#355

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1624 (b2abf69) into main (48858c2) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
+ Coverage   89.38%   89.52%   +0.14%     
==========================================
  Files          42       42              
  Lines        2166     2168       +2     
==========================================
+ Hits         1936     1941       +5     
+ Misses        230      227       -3     
Impacted Files Coverage Δ
src/auth.cmd.js 92.85% <ø> (ø)
src/remotepublish.cmd.js 97.97% <ø> (+1.01%) ⬆️
src/deploy.cmd.js 84.22% <100.00%> (+0.05%) ⬆️
src/perf.cmd.js 46.01% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b55227...b2abf69. Read the comment docs.

@tripodsan
Copy link
Contributor Author

now the windows tests fail....oh my..... I'll look at them tomorrow...but feel free :-)

Copy link
Contributor

@stefan-guggisberg stefan-guggisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the auth option which obviously didn't work for a long time and nobody noticed.

src/deploy.cmd.js Show resolved Hide resolved
src/deploy.cmd.js Show resolved Hide resolved
@stefan-guggisberg
Copy link
Contributor

related: adobe/helix-home#182

@tripodsan
Copy link
Contributor Author

tripodsan commented Jan 28, 2021

now the windows tests fail....oh my..... I'll look at them tomorrow...but feel free :-)

hmmm:

  1) Integration test for build
       build can use a custom pipeline from git tag:
     AssertionError [ERR_ASSERTION]: Expected file at helix-cli\test\tmp\4a5dac391c19377d42001ab7c14052c4\.hlx\build\node_modules\@adobe\helix-pipeline\package.json exists
      at assertFile (test\utils.js:59:12)
      at Context.<anonymous> (test\testBuildCmd.js:112:5)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  2) hlx package (custom pipeline)
       package installs the correct custom pipeline via directory:
     Error: exec: fatal: cannot create directory at 'test/fixtures/Testing-HTML-Pipeline-universal-_1522650794/html-pipe-complains-with-a-specific-message-for-mdast-nodes-wih-extra-properties-when-con_3402660966': Filename too long
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'


      at Object.error (node_modules\shelljs\src\common.js:110:27)
      at execSync (node_modules\shelljs\src\exec.js:102:12)
      at Object._exec (node_modules\shelljs\src\exec.js:205:12)
      at Object.exec (node_modules\shelljs\src\common.js:335:23)
      at Context.<anonymous> (test\testPackageCmd.js:195:7)

  3) Integration test for up command (custom pipeline)
       up command uses the correct custom pipeline with directory:
     Error: exec: fatal: cannot create directory at 'test/fixtures/Testing-HTML-Pipeline-universal-_1522650794/html-pipe-complains-with-a-specific-message-for-mdast-nodes-wih-extra-properties-when-con_3402660966': Filename too long
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

@tripodsan
Copy link
Contributor Author

the windows tests on circleci are different than the ones I get locally...

@tripodsan tripodsan merged commit 5cda357 into main Jan 29, 2021
@tripodsan tripodsan deleted the helix-fetch-v2 branch January 29, 2021 07:11
adobe-bot pushed a commit that referenced this pull request Jan 29, 2021
# [13.1.0](v13.0.47...v13.1.0) (2021-01-29)

### Bug Fixes

* **deps:** update adobe fixes ([#1626](#1626)) ([2528ec1](2528ec1))

### Features

* **deps:** upgrade to helix-fetch v2 ([#1624](#1624)) ([5cda357](5cda357))
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 13.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants