New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): upgrade to helix-fetch v2 #1624
Conversation
This PR will trigger a minor release when merged. |
@@ -41,7 +41,7 @@ | |||
"archiver": "^5.1.0", | |||
"camelcase": "^6.2.0", | |||
"chalk": "4.1.0", | |||
"chokidar": "^3.4.3", | |||
"chokidar": "3.4.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was needed, because I got errors on macOS.
see: fsevents/fsevents#355
Codecov Report
@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
+ Coverage 89.38% 89.52% +0.14%
==========================================
Files 42 42
Lines 2166 2168 +2
==========================================
+ Hits 1936 1941 +5
+ Misses 230 227 -3
Continue to review full report at Codecov.
|
now the windows tests fail....oh my..... I'll look at them tomorrow...but feel free :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from the auth
option which obviously didn't work for a long time and nobody noticed.
related: adobe/helix-home#182 |
hmmm:
|
the windows tests on circleci are different than the ones I get locally... |
🎉 This PR is included in version 13.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.