Add GitHub Enterprise support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad-m
reviewed
Feb 14, 2022
|
I don't have access to GitHub Enterprise, so I merge as is and I hope that it works. Could you verify by testing |
|
@ad-m Sure, I can test it. |
jackton1
suggested changes
Feb 17, 2022
jackton1
suggested changes
Feb 17, 2022
jackton1
reviewed
Feb 17, 2022
jackton1
approved these changes
Feb 18, 2022
ad-m
added a commit
that referenced
this pull request
Feb 18, 2022
|
I reversed that PR as it break build. https://github.com/ad-m/github-push-action/runs/5245447913?check_suite_focus=true Feel free to resubmit after fixing that build. Should we use |
jackton1
reviewed
Feb 18, 2022
| if (!branch) { | ||
| const headers = { | ||
| 'User-Agent': 'github.com/ad-m/github-push-action' | ||
| }; | ||
| if (process.env.INPUT_GITHUB_TOKEN) headers.Authorization = `token ${process.env.INPUT_GITHUB_TOKEN}`; | ||
| const body = JSON.parse(await get(`https://api.github.com/repos/${repository}`, { headers })) | ||
| const api_url = github_url === 'github.com' ? 'api.github.com' : github_url + '/api/v3'; |
There was a problem hiding this comment.
Thanks, for the hint. I've opened a fresh modified draft PR.
|
@ad-m does the test also run on PR’s from forks ? We might’ve caught this earlier. |
ZPascal
pushed a commit
to ZPascal/github-push-action
that referenced
this pull request
Apr 18, 2022
* Update the GitHub action Update build.yml Remove push command Add GitHub Enterprise support (ad-m#106) * Add GitHub url and GitHub Enterprise support * Add review improvements * Modify the default value to github.server_url Revert "Add GitHub Enterprise support (ad-m#106)" (ad-m#107) This reverts commit a7824cd. Add a PR validation action (ad-m#109) Added workaround as suggested by the git itself (ad-m#112) * Added workaround as suggested by the git itself * Update start.sh Co-authored-by: Pascal Zimmermann <Z_pascal@yahoo.de> Co-authored-by: aleksandr.abroskin <aleksandr.abroskin@getmoss.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Pascal Zimmermann <Z_pascal@yahoo.de> Update the PR and remove the test mode Delete build-pr.yml Add first version of deploy keys support Update the README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ad-m, I've modified the push action a bit to specify the used GitHub URL and make it possible to support GitHub Enterprise instances.
Regards,
ZPascal