Change hash to digest for consistent terminology across runner logs #1991
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link-
reviewed
Mar 12, 2025
| @@ -98,7 +98,7 @@ export async function uploadZipToBlobStorage( | |||
|
|
|||
| hashStream.end() | |||
| sha256Hash = hashStream.read() as string | |||
There was a problem hiding this comment.
Wouldn't this apply to the variable names too?
There was a problem hiding this comment.
This is a great question that I'm sure we could spend a lot of time thinking about. My view is that we're using a hashing algorithm, so hashStream is the correct term, the hash stream produces a hash, which can also be referred to as a digest, so we could probably go either way on whether or not to rename sha256hash here.
I'd generally lean towards the minimal change as it intuitively makes sense to me that a hashStream would produce a hash, but I'm open to renaming it if you have a more appropriate name for this variable in mind.
Link-
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of digest validation on artifact download, taking this opportunity to change the message printed during upload to use the same terminology.