Update GHES host check #1648
Merged
Update GHES host check #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const hostname = ghUrl.hostname.trimEnd().toUpperCase() | ||
| const isGitHubHost = (hostname == 'GITHUB.COM') | ||
| const isProximaHost = (hostname.endsWith('GHE.COM') || hostname.endsWith('GHE.LOCALHOST')) |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
There was a problem hiding this comment.
Incomplete URL substring sanitization
'GHE.COM' may be preceded by an arbitrary host name.
updating alowed hosts in artifact ghes check using dot prepend ghe host
eggyhead
force-pushed
the
eggyhead/ghescheck-updatehosts
branch
from
1e316cc
to
3b02a6f
Compare
yacaovsnc
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are we doing?
Currently, we are only checking equality against
github.comto ensure artifact and cache actions are being run in a non-enterprise host. We need to update this check to allow requests fromghe.comandghe.localhost, additional allowed hostnames for production and local development.Fixes https://github.com/github/actions-results-team/issues/2208
How are we doing it?
isGhesHow do I test?