cache - getCacheVersion - dup paths array

[MSP-Greg]

Previous to commit b2d865f, code used components = paths.concat(...), which left paths unchanged.

The commit changed to using components = paths, then pushing onto components later. This changes the paths array.

Closes #1377

[MSP-Greg]

Not sure how deep the copy/clone should be. Maybe a better choice would be the below, or something similar:

JSON.parse(JSON.stringify(arr))

EDIT: js isn't my 'primary' langauge, at least for several years. I think .slice() should work...

[MSP-Greg]

I think the below is a fairly common pattern using this code is:

// full_key is often generated from dependency lock file
restoreKey = restoreCache(paths, full_key, partialKeys)
if (restoreKey !== full_key) {
  // update dependencies
  saveCache(paths, full_key)
}

So, if paths is being changed by the code here, the version from getCacheVersion will change.

Consumers of the code can replace restoreCache(paths, full_key, partialKeys) with restoreCache(paths.slice(), full_key, partialKeys) or an equivalent. Regardless, the code here should not be changing parameters passed to its functions...

[WebeWizard]

bump. I think a lot of people have been patiently waiting for this fix.

[deemp]

@kotewar, @rentziass, please, review this PR.

The fix suggested in #1378 (comment) worked for me.

After nix-community/cache-nix-action@93041f2 cache was restored successfully in the second run https://github.com/deemp/cache-nix-too/actions/runs/5573652888/jobs/10181692942#step:4:19

[threeal]

When are we going to merge this? I just stumble upon this issue too

[ali-kafel]

I have run into this issue as well can we merge and release please?

[ali-kafel]

@robherley @bethanyj28 @konradpabjan Sorry for mentioning you but it would be great if we could get a review on this from the actions team

[robherley]

👋 The @actions/cache package now has this fix within v3.2.3, thanks for the contribution!