fix: docker-publish.yml cosign command line args when multiple tags are present #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnuphong
approved these changes
Jul 17, 2022
arnuphong
approved these changes
Jul 17, 2022
i-am-gizm0
added a commit
to i-am-gizm0/svelte-gallery
that referenced
this pull request
Jul 23, 2022
A known issue in this workflow: actions/starter-workflows#1620 - images with multiple tags fail to sign because the tags span multiple lines. This is the fix proposed in actions/starter-workflows#1622
i-am-gizm0
added a commit
to i-am-gizm0/svelte-gallery
that referenced
this pull request
Jul 23, 2022
* Replace old Docker build test with build on PR and push on schedule and release * Fix commit signing A known issue in this workflow: actions/starter-workflows#1620 - images with multiple tags fail to sign because the tags span multiple lines. This is the fix proposed in actions/starter-workflows#1622
Phantsure
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With scheduled builds the output docker image has two tags - branch name (eg, main) and nightly.
The current template is passing these as a single argument into the cosign sign command. This is causing failures of the workflow when run with a scheduled trigger.
This change splits them using xargs and runs multiple cosign commands, one for each tag.
Tested by running against one of my own repos, eg: https://github.com/jamesmoore/mp3info/runs/7087514897?check_suite_focus=true#step:8:2