Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deleting the branch in the upstream of a forked repo #913

Merged
merged 3 commits into from Jan 26, 2023
Merged

Skip deleting the branch in the upstream of a forked repo #913

merged 3 commits into from Jan 26, 2023

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Jan 11, 2023

Description:
Handle an attempt of the deleting a branch in a forked repo

When the action runs against the repo that has PRs from the forked repo it attempted to delete the branch from the fork repo and failed.

The PR fix this.

Related issue:
link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame marked this pull request as ready for review January 24, 2023 08:04
@dsame dsame requested a review from a team as a code owner January 24, 2023 08:04
@dsame dsame self-assigned this Jan 24, 2023
Copy link
Contributor

@marko-zivic-93 marko-zivic-93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if the main logic is actually ok, due to lack of my personal understanding about the issue, but if other guys from the team agree that it is ok, I am all for it 😄

@dsame dsame merged commit c4a13d8 into actions:main Jan 26, 2023
kayman-mk pushed a commit to Hapag-Lloyd/Repository-Templates that referenced this pull request Nov 19, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/stale](https://togithub.com/actions/stale) | action | major |
`v7.0.0` -> `v8.0.0` |

---

### Release Notes

<details>
<summary>actions/stale (actions/stale)</summary>

### [`v8.0.0`](https://togithub.com/actions/stale/releases/tag/v8.0.0)

[Compare
Source](https://togithub.com/actions/stale/compare/v7.0.0...v8.0.0)

:warning: This version contains breaking changes :warning:

#### What's Changed

- New option labels-to-remove-when-stale enables users to specify list
of comma delimited labels that will be removed when the issue or PR
becomes stale by [@&#8203;panticmilos](https://togithub.com/panticmilos)
[actions/stale#770
- Skip deleting the branch in the upstream of a forked repo by
[@&#8203;dsame](https://togithub.com/dsame)
[actions/stale#913
- abort the build on the error by
[@&#8203;dsame](https://togithub.com/dsame) in
[actions/stale#935

#### Breaking Changes

- In this release we prevent scenarios when the build is not interrupted
on some exceptions, which led to successful builds when they are
supposed to fail

#### Example

```yaml
name: 'Remove labels when the issue or PR becomes stale'
on:
  schedule:
    - cron: '30 1 * * *'

permissions:
    pull-requests: write

jobs:
  stale:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/stale@v8
        with:
          labels-to-remove-when-stale: 'label1,label2'
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/Repository-Templates).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kayman-mk pushed a commit to Hapag-Lloyd/Renovate-Global-Configuration that referenced this pull request Nov 19, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/stale](https://togithub.com/actions/stale) | action | major |
`v7.0.0` -> `v8.0.0` |

---

### Release Notes

<details>
<summary>actions/stale (actions/stale)</summary>

### [`v8.0.0`](https://togithub.com/actions/stale/releases/tag/v8.0.0)

[Compare
Source](https://togithub.com/actions/stale/compare/v7.0.0...v8.0.0)

:warning: This version contains breaking changes :warning:

#### What's Changed

- New option labels-to-remove-when-stale enables users to specify list
of comma delimited labels that will be removed when the issue or PR
becomes stale by [@&#8203;panticmilos](https://togithub.com/panticmilos)
[actions/stale#770
- Skip deleting the branch in the upstream of a forked repo by
[@&#8203;dsame](https://togithub.com/dsame)
[actions/stale#913
- abort the build on the error by
[@&#8203;dsame](https://togithub.com/dsame) in
[actions/stale#935

#### Breaking Changes

- In this release we prevent scenarios when the build is not interrupted
on some exceptions, which led to successful builds when they are
supposed to fail

#### Example

```yaml
name: 'Remove labels when the issue or PR becomes stale'
on:
  schedule:
    - cron: '30 1 * * *'

permissions:
    pull-requests: write

jobs:
  stale:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/stale@v8
        with:
          labels-to-remove-when-stale: 'label1,label2'
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants