Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option labels-to-remove-when-stale #771

Closed

Conversation

arnodirlam
Copy link

Changes

Adds option labels-to-remove-when-stale.

Context

Resolves #770.

@arnodirlam arnodirlam requested a review from a team as a code owner July 5, 2022 20:57
@arnodirlam arnodirlam changed the title Add option labels-to-remove-when-unstale Add option labels-to-remove-when-stale Jul 5, 2022
@@ -802,6 +808,7 @@ export class IssuesProcessor {
issue_number: issue.number,
labels: [staleLabel]
});
await this._removeLabels(issue, labelsToRemoveWhenStale, Option.LabelsToRemoveWhenStale);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the behavior if we attempt to remove a label that isn't currently on the issue/PR? Does it block others from being removed? Or does it no-op and move on?

Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @arnodirlam!

Just a heads up: You'll need to run npm run pack in order to generate the JS file from the TS.

@github-actions github-actions bot added the Stale label Aug 18, 2022
@github-actions github-actions bot closed this Aug 23, 2022
@cthomaspdx
Copy link

This would be really great option to have. Seems like the stale bot did too good of a job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels-to-remove-when-stale option
3 participants