Trim python version when reading from file #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error on the checks seemed to be due to LF ending instead of CLRF. Just force pushed my commit due to that. Would you mind triggering the checks again? |
|
Hello @FerranPares. I've started checks. Could you please confirm if you'd like us to push commit on your branch with a regenerated dist ? |
Sure @dmitry-shibanov! Feel free to do that! |
2 tasks
kurtmckee
approved these changes
Sep 11, 2023
|
This PR has some merge conflicts, but looks good to me otherwise. 👍 |
Updated the PR to resolve the conflicts. Ready to run the workflows and merge if everything is alright @kurtmckee |
|
@FerranPares I don't have any permissions to the repo; I'm a contributor like you. 😀 |
Oohhhh, I see |
|
@kurtmckee All checks passed after refactor. If you approve back again we can finally merge this 🙏 (this PR has been around for too long). |
dmitry-shibanov
approved these changes
Oct 6, 2023
renovate bot
added a commit
to rpdelaney/downforeveryone
that referenced
this pull request
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | minor | `v4.7.1` -> `v4.8.0` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([actions/setup-python#694). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@​FerranPares](https://togithub.com/FerranPares) in [actions/setup-python#628 - Use non-deprecated versions in examples by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#724 - Change deprecation comment to past tense by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#723 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#743 - advanced-usage.md: Encourage the use actions/checkout@v4 by [@​cclauss](https://togithub.com/cclauss) in [actions/setup-python#729 - Examples now use checkout@v4 by [@​simonw](https://togithub.com/simonw) in [actions/setup-python#738 - Update actions/checkout to v4 by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#761 #### New Contributors - [@​FerranPares](https://togithub.com/FerranPares) made their first contribution in [actions/setup-python#628 - [@​timfel](https://togithub.com/timfel) made their first contribution in [actions/setup-python#694 - [@​jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [actions/setup-python#724 **Full Changelog**: actions/setup-python@v4...v4.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rpdelaney/downforeveryone). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
averikitsch
pushed a commit
to GoogleCloudPlatform/genai-databases-retrieval-app
that referenced
this pull request
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | minor | `v4.7.1` -> `v4.8.0` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([actions/setup-python#694). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@​FerranPares](https://togithub.com/FerranPares) in [actions/setup-python#628 - Use non-deprecated versions in examples by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#724 - Change deprecation comment to past tense by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#723 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#743 - advanced-usage.md: Encourage the use actions/checkout@v4 by [@​cclauss](https://togithub.com/cclauss) in [actions/setup-python#729 - Examples now use checkout@v4 by [@​simonw](https://togithub.com/simonw) in [actions/setup-python#738 - Update actions/checkout to v4 by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#761 #### New Contributors - [@​FerranPares](https://togithub.com/FerranPares) made their first contribution in [actions/setup-python#628 - [@​timfel](https://togithub.com/timfel) made their first contribution in [actions/setup-python#694 - [@​jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [actions/setup-python#724 **Full Changelog**: actions/setup-python@v4...v4.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GoogleCloudPlatform/genai-databases-retrieval-app). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
rpdelaney
added a commit
to rpdelaney/uncolor
that referenced
this pull request
Dec 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | major | `v4.7.0` -> `v5.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [flake8](https://togithub.com/pycqa/flake8) ([changelog](https://flake8.pycqa.org/en/latest/release-notes/index.html)) | dev-dependencies | major | `5.0.4` -> `6.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v5.0.0`](https://togithub.com/actions/setup-python/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.8.0...v5.0.0) #### What's Changed In scope of this release, we update node version runtime from node16 to node20 ([actions/setup-python#772). Besides, we update dependencies to the latest versions. **Full Changelog**: actions/setup-python@v4.8.0...v5.0.0 ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([actions/setup-python#694). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@​FerranPares](https://togithub.com/FerranPares) in [actions/setup-python#628 - Use non-deprecated versions in examples by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#724 - Change deprecation comment to past tense by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#723 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#743 - advanced-usage.md: Encourage the use actions/checkout@v4 by [@​cclauss](https://togithub.com/cclauss) in [actions/setup-python#729 - Examples now use checkout@v4 by [@​simonw](https://togithub.com/simonw) in [actions/setup-python#738 - Update actions/checkout to v4 by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#761 #### New Contributors - [@​FerranPares](https://togithub.com/FerranPares) made their first contribution in [actions/setup-python#628 - [@​timfel](https://togithub.com/timfel) made their first contribution in [actions/setup-python#694 - [@​jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [actions/setup-python#724 **Full Changelog**: actions/setup-python@v4...v4.8.0 ### [`v4.7.1`](https://togithub.com/actions/setup-python/releases/tag/v4.7.1) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.0...v4.7.1) #### What's Changed - Bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#702 - Add range validation for toml files by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#726 **Full Changelog**: actions/setup-python@v4...v4.7.1 </details> <details> <summary>pycqa/flake8 (flake8)</summary> ### [`v6.1.0`](https://togithub.com/pycqa/flake8/compare/6.0.0...6.1.0) [Compare Source](https://togithub.com/pycqa/flake8/compare/6.0.0...6.1.0) ### [`v6.0.0`](https://togithub.com/pycqa/flake8/compare/5.0.4...6.0.0) [Compare Source](https://togithub.com/pycqa/flake8/compare/5.0.4...6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rpdelaney/uncolor). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
petretiandrea
pushed a commit
to petretiandrea/home-assistant-tapo-p100
that referenced
this pull request
Dec 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | major | `v4.7.1` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v5.0.0`](https://togithub.com/actions/setup-python/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.8.0...v5.0.0) #### What's Changed In scope of this release, we update node version runtime from node16 to node20 ([actions/setup-python#772). Besides, we update dependencies to the latest versions. **Full Changelog**: actions/setup-python@v4.8.0...v5.0.0 ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([actions/setup-python#694). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@​FerranPares](https://togithub.com/FerranPares) in [actions/setup-python#628 - Use non-deprecated versions in examples by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#724 - Change deprecation comment to past tense by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#723 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#743 - advanced-usage.md: Encourage the use actions/checkout@v4 by [@​cclauss](https://togithub.com/cclauss) in [actions/setup-python#729 - Examples now use checkout@v4 by [@​simonw](https://togithub.com/simonw) in [actions/setup-python#738 - Update actions/checkout to v4 by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#761 #### New Contributors - [@​FerranPares](https://togithub.com/FerranPares) made their first contribution in [actions/setup-python#628 - [@​timfel](https://togithub.com/timfel) made their first contribution in [actions/setup-python#694 - [@​jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [actions/setup-python#724 **Full Changelog**: actions/setup-python@v4...v4.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/petretiandrea/home-assistant-tapo-p100). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
lambchop4prez
added a commit
to lambchop4prez/network
that referenced
this pull request
Apr 7, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | major | `v4.7.0` -> `v5.1.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v5.1.0`](https://togithub.com/actions/setup-python/releases/tag/v5.1.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v5.0.0...v5.1.0) #### What's Changed - Leveraging the raw API to retrieve the version-manifest, as it does not impose a rate limit and hence facilitates unrestricted consumption without the need for a token for Github Enterprise Servers by [@​Shegox](https://togithub.com/Shegox) in [actions/setup-python#766. - Dependency updates by [@​dependabot](https://togithub.com/dependabot) and [@​HarithaVattikuti](https://togithub.com/HarithaVattikuti) in [actions/setup-python#817 - Documentation changes for version in README by [@​basnijholt](https://togithub.com/basnijholt) in [actions/setup-python#776 - Documentation changes for link in README by [@​ukd1](https://togithub.com/ukd1) in [actions/setup-python#793 - Documentation changes for link in Advanced Usage by [@​Jamim](https://togithub.com/Jamim) in [actions/setup-python#782 - Documentation changes for avoiding rate limit issues on GHES by [@​priya-kinthali](https://togithub.com/priya-kinthali) in [actions/setup-python#835 #### New Contributors - [@​basnijholt](https://togithub.com/basnijholt) made their first contribution in [actions/setup-python#776 - [@​ukd1](https://togithub.com/ukd1) made their first contribution in [actions/setup-python#793 - [@​Jamim](https://togithub.com/Jamim) made their first contribution in [actions/setup-python#782 - [@​Shegox](https://togithub.com/Shegox) made their first contribution in [actions/setup-python#766 - [@​priya-kinthali](https://togithub.com/priya-kinthali) made their first contribution in [actions/setup-python#835 **Full Changelog**: actions/setup-python@v5.0.0...v5.1.0 ### [`v5.0.0`](https://togithub.com/actions/setup-python/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.8.0...v5.0.0) #### What's Changed In scope of this release, we update node version runtime from node16 to node20 ([actions/setup-python#772). Besides, we update dependencies to the latest versions. **Full Changelog**: actions/setup-python@v4.8.0...v5.0.0 ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([actions/setup-python#694). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@​FerranPares](https://togithub.com/FerranPares) in [actions/setup-python#628 - Use non-deprecated versions in examples by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#724 - Change deprecation comment to past tense by [@​jeffwidman](https://togithub.com/jeffwidman) in [actions/setup-python#723 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#743 - advanced-usage.md: Encourage the use actions/checkout@v4 by [@​cclauss](https://togithub.com/cclauss) in [actions/setup-python#729 - Examples now use checkout@v4 by [@​simonw](https://togithub.com/simonw) in [actions/setup-python#738 - Update actions/checkout to v4 by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#761 #### New Contributors - [@​FerranPares](https://togithub.com/FerranPares) made their first contribution in [actions/setup-python#628 - [@​timfel](https://togithub.com/timfel) made their first contribution in [actions/setup-python#694 - [@​jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [actions/setup-python#724 **Full Changelog**: actions/setup-python@v4...v4.8.0 ### [`v4.7.1`](https://togithub.com/actions/setup-python/releases/tag/v4.7.1) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.0...v4.7.1) #### What's Changed - Bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [actions/setup-python#702 - Add range validation for toml files by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-python#726 **Full Changelog**: actions/setup-python@v4...v4.7.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/lambchop4prez/network). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Just adding a trim after reading the python version from
.python-versionfile or similar, so even if that file contains a newline at the EOF, it will be properly parsed.It seems that python
versionconst may include the newline when parsing from a file and avoid matching it the proper python version to install afterwards.Check list: