Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to use node20 runtime, actions/checkout to v4 #846

Closed
wants to merge 2 commits into from

Conversation

kbdharun
Copy link

@kbdharun kbdharun commented Sep 5, 2023

Description:

Node20 was added to Actions Runner on v2.308.0 and Node16 reaches end of life soon on 11 Sep 2023.

Therefore, This PR updates the default runtime to node20. I have bumped the actions/checkout version to v4 for the same.

Related issue:

actions/runner#2732

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

A major version bump might be needed after the PRs merge.

@kbdharun kbdharun requested a review from a team as a code owner September 5, 2023 03:59
@dmitry-shibanov
Copy link
Contributor

Hello @kbdharun. Thank you for your pull request. Could you please revert changes in docs/advanced-usage.md

@armingdev
Copy link

Any update on this?

@o-alexandrov
Copy link

o-alexandrov commented Sep 30, 2023

Just curious, why the docs needed a revert, if one of this PR's points is to bump actions/checkout to v4 and starting October 23rd 2023, users will start seeing deprecated notice due to node.js 16 being used in actions/checkout@v3

  • is it a battle for who makes more code line changes? :D

@kbdharun
Copy link
Author

This seems to be superseded and completed in #866.

@kbdharun kbdharun closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants