Code review

actions · Dec 28, 2023 · 241a772 · 241a772
1 parent 70da331
commit 241a772
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dist/cache-save/index.js b/dist/cache-save/index.js
@@ -83348,7 +83348,7 @@ function getNodeVersionFromFile(versionFilePath) {
     try {
         const manifest = JSON.parse(contents);
         // Presume package.json file.
-        if (typeof manifest === 'object' && manifest !== null) {
+        if (typeof manifest === 'object' && !!manifest) {
             // Support Volta.
             // See https://docs.volta.sh/guide/understanding#managing-your-project
             if ((_a = manifest.volta) === null || _a === void 0 ? void 0 : _a.node) {

diff --git a/dist/setup/index.js b/dist/setup/index.js
@@ -93795,7 +93795,7 @@ function getNodeVersionFromFile(versionFilePath) {
     try {
         const manifest = JSON.parse(contents);
         // Presume package.json file.
-        if (typeof manifest === 'object' && manifest !== null) {
+        if (typeof manifest === 'object' && !!manifest) {
             // Support Volta.
             // See https://docs.volta.sh/guide/understanding#managing-your-project
             if ((_a = manifest.volta) === null || _a === void 0 ? void 0 : _a.node) {

diff --git a/src/util.ts b/src/util.ts
@@ -18,7 +18,7 @@ export function getNodeVersionFromFile(versionFilePath: string): string | null {
     const manifest = JSON.parse(contents);
 
     // Presume package.json file.
-    if (typeof manifest === 'object' && manifest !== null) {
+    if (typeof manifest === 'object' && !!manifest) {
       // Support Volta.
       // See https://docs.volta.sh/guide/understanding#managing-your-project
       if (manifest.volta?.node) {