Upgrade Node to v20 #558
Merged
Upgrade Node to v20 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| name: 'Setup Java JDK' | |||
| nnname: 'Setup Java JDK' | |||
There was a problem hiding this comment.
Could you please revert this changes.
There was a problem hiding this comment.
@dmitry-shibanov reverted the changes. Thank you.
action.yml
Outdated
| @@ -78,6 +78,6 @@ outputs: | |||
| cache-hit: | |||
| description: 'A boolean value to indicate an exact match was found for the primary key' | |||
| runs: | |||
| using: 'node16' | |||
| using: 'node21' | |||
There was a problem hiding this comment.
Could you please change it to node20. If you used the npm ci command with node 21 on local machine you need to change it node20 and regenerate dependencies with it.
There was a problem hiding this comment.
@dmitry-shibanov Updated node version to 2o and build sucessful in my local.
package.json
Outdated
| "url": "https://github.com/actions/setup-java/issues" | ||
| }, | ||
| "homepage": "https://github.com/actions/setup-java#readme", | ||
| "directories": { |
There was a problem hiding this comment.
You can remove directories part.
aparnajyothi-y
changed the title
|
@MaksimZhukov @dmitry-shibanov I have resolved the conflicts. Please review. Thank you. |
MaksimZhukov
previously approved these changes
Nov 23, 2023
.github/workflows/check-dist.yml
Outdated
| @@ -15,3 +15,5 @@ jobs: | |||
| call-check-dist: | |||
| name: Check dist/ | |||
| uses: actions/reusable-workflows/.github/workflows/check-dist.yml@main | |||
| with: | |||
There was a problem hiding this comment.
Suggested change
| with: | |
| with: |
There was a problem hiding this comment.
Updated the format and removed the conflicts. Please review.
MaksimZhukov
dismissed
their stale review
The branch has conflicts that must be resolved
MaksimZhukov
approved these changes
Nov 24, 2023
IvanZosimov
approved these changes
Nov 27, 2023
dmitry-shibanov
approved these changes
Nov 28, 2023
zeebe-bors-camunda bot
added a commit
to camunda/zeebe
that referenced
this pull request
Dec 7, 2023
15484: deps(github-tags): Update actions/setup-java action to v4 (main) r=oleschoenburg a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-java](https://togithub.com/actions/setup-java) | action | major | `v3.13.0` -> `v4.0.0` | | [actions/setup-java](https://togithub.com/actions/setup-java) | action | major | `v3` -> `v4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v4.0.0`](https://togithub.com/actions/setup-java/releases/tag/v4.0.0) [Compare Source](https://togithub.com/actions/setup-java/compare/v3.13.0...v4.0.0) #### What's Changed In the scope of this release, the version of the Node.js runtime was updated to 20. The majority of dependencies were updated to the latest versions. From now on, the code for the setup-java will run on Node.js 20 instead of Node.js 16. #### Breaking changes - Update Node.js runtime to version 20 by [`@​aparnajyothi-y](https://togithub.com/aparnajyothi-y)` in [actions/setup-java#558 #### Non-breaking changes - Adding support for microsoft openjdk 21.0.0 by [`@​ralfstuckert](https://togithub.com/ralfstuckert)` in [actions/setup-java#546 - Update [`@​actions/cache](https://togithub.com/actions/cache)` dependency and documentation by [`@​IvanZosimov](https://togithub.com/IvanZosimov)` in [actions/setup-java#549 - Implementation of the cache-dependency-path option to control caching dependency by [`@​itchyny](https://togithub.com/itchyny)` in [actions/setup-java#499 #### New Contributors - [`@​ralfstuckert](https://togithub.com/ralfstuckert)` made their first contribution in [actions/setup-java#546 - [`@​itchyny](https://togithub.com/itchyny)` made their first contribution in [actions/setup-java#499 **Full Changelog**: actions/setup-java@v3...v4.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 8pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes added for the node-version upgrade from 16 to 20 for actions/setup-java
Related issue:
Feature request
Check list: