feat: implement cache-dependency-path option to control caching dependency #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
feat-cache-dependency-path
branch
from
81cfbd4
to
5111922
Compare
itchyny
force-pushed
the
feat-cache-dependency-path
branch
from
5111922
to
a56fdde
Compare
|
Hmm, I was worried about the complexity of listing dependency files, but I noticed that |
nmamlm
approved these changes
Jun 13, 2023
|
Any chance to get this merged? Despite my previous comment, I think this is the actions/* way since this option is supported not only by setup-node, but setup-go and setup-python. |
|
Hi, @itchyny 👋 Thank you for the contribution! We will take a look and get back to you with our decision regarding it. |
ZimvoMatwa
approved these changes
Jun 28, 2023
|
Oops, I thought the CI failure is something flaky, but it's just about code formatting. I'll fix this soon. |
itchyny
force-pushed
the
feat-cache-dependency-path
branch
from
a56fdde
to
50b7edd
Compare
IvanZosimov
added
feature request
itchyny
force-pushed
the
feat-cache-dependency-path
branch
from
50b7edd
to
a8e0c55
Compare
IvanZosimov
suggested changes
Nov 8, 2023
src/cache.ts
Outdated
| return `${CACHE_KEY_PREFIX}-${process.env['RUNNER_OS']}-${packageManager.id}-${hash}`; | ||
| async function computeCacheKey( | ||
| packageManager: PackageManager, | ||
| cacheDependencyPath?: string |
There was a problem hiding this comment.
In the current implementation of the getInput() function, cacheDependencyPath can't be undefined as if it's not supplied to the workflow file, its value will be an empty string.
|
Hi @itchyny, I left some comments to your PR, please check them out. Also, I think it'd be great to update the list of inputs in the |
itchyny
force-pushed
the
feat-cache-dependency-path
branch
6 times, most recently
from
8d6fd83
to
3a33295
Compare
itchyny
force-pushed
the
feat-cache-dependency-path
branch
from
3a33295
to
558c948
Compare
IvanZosimov
approved these changes
Nov 15, 2023
dsame
approved these changes
Nov 15, 2023
nikolai-laevskii
approved these changes
Nov 15, 2023
IvanZosimov
suggested changes
Nov 16, 2023
IvanZosimov
approved these changes
Nov 17, 2023
MaksimZhukov
approved these changes
Nov 17, 2023
marko-zivic-93
approved these changes
Nov 22, 2023
dmitry-shibanov
approved these changes
Nov 22, 2023
dusan-trickovic
approved these changes
Nov 22, 2023
zeebe-bors-camunda bot
added a commit
to camunda/zeebe
that referenced
this pull request
Dec 7, 2023
15484: deps(github-tags): Update actions/setup-java action to v4 (main) r=oleschoenburg a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-java](https://togithub.com/actions/setup-java) | action | major | `v3.13.0` -> `v4.0.0` | | [actions/setup-java](https://togithub.com/actions/setup-java) | action | major | `v3` -> `v4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v4.0.0`](https://togithub.com/actions/setup-java/releases/tag/v4.0.0) [Compare Source](https://togithub.com/actions/setup-java/compare/v3.13.0...v4.0.0) #### What's Changed In the scope of this release, the version of the Node.js runtime was updated to 20. The majority of dependencies were updated to the latest versions. From now on, the code for the setup-java will run on Node.js 20 instead of Node.js 16. #### Breaking changes - Update Node.js runtime to version 20 by [`@​aparnajyothi-y](https://togithub.com/aparnajyothi-y)` in [actions/setup-java#558 #### Non-breaking changes - Adding support for microsoft openjdk 21.0.0 by [`@​ralfstuckert](https://togithub.com/ralfstuckert)` in [actions/setup-java#546 - Update [`@​actions/cache](https://togithub.com/actions/cache)` dependency and documentation by [`@​IvanZosimov](https://togithub.com/IvanZosimov)` in [actions/setup-java#549 - Implementation of the cache-dependency-path option to control caching dependency by [`@​itchyny](https://togithub.com/itchyny)` in [actions/setup-java#499 #### New Contributors - [`@​ralfstuckert](https://togithub.com/ralfstuckert)` made their first contribution in [actions/setup-java#546 - [`@​itchyny](https://togithub.com/itchyny)` made their first contribution in [actions/setup-java#499 **Full Changelog**: actions/setup-java@v3...v4.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 8pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements a new option
cache-dependency-pathto control caching dependency.This option originates from setup-node, and is useful for monorepos.
Related issue:
Check list: