Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize the .tool-versions file to set expected Go version #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Utilize the .tool-versions file to set expected Go version #402

wants to merge 1 commit into from

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Jul 27, 2023

Description:

Add '.tool-versions' to 'go.mod' and 'go.work' as a source of the go version

Related issue:
link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame requested a review from a team as a code owner July 27, 2023 17:37
@dsame dsame linked an issue Jul 27, 2023 that may be closed by this pull request
feat: Utilize the.tool-versions file to set expected Go version #375
Open
@plukevdh plukevdh mentioned this pull request Aug 8, 2023
Closed
2 tasks
@troian
Copy link

troian commented Aug 10, 2023

isn't it already implemented in go1.21's go.mod as toolchain option?

@dsame dsame mentioned this pull request Aug 11, 2023
Open
2 tasks
v1v added a commit to v1v/setup-go that referenced this pull request Aug 15, 2023
@v1v
docs: add tiny reference for the .tool-versions
721bdf3 
See actions#402
@dsame dsame mentioned this pull request Aug 16, 2023
Open
@dsame
Copy link
Contributor Author

dsame commented Aug 16, 2023

the merging is blocked by #375 (comment)

@dsame
Copy link
Contributor Author

dsame commented Aug 16, 2023

Hello @troian

isn't it already implemented in go1.21's go.mod as toolchain option?

i don't think so, because we still have to use the action with the versions prior 1.21 and toolchain option is different in the mean it can call out for different go versions used for build/test/lint tasks. But thank you for pointing out this new feature - it should be incorporated into the action. It would be good to create the feature request .

Kleigh1003
Kleigh1003 reviewed Dec 30, 2023
View reviewed changes
Copy link

@Kleigh1003 Kleigh1003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetch text 8439997576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kleigh1003 Kleigh1003 Kleigh1003 left review comments

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

@dusan-trickovic dusan-trickovic dusan-trickovic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Utilize the.tool-versions file to set expected Go version
5 participants
@dsame @troian @marko-zivic-93 @dusan-trickovic @Kleigh1003