Enable caching by default #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid vague `default` value in many places
In order to hande empty 'cache' input
It is needed to enable cache
| @@ -13,3 +13,5 @@ export const supportedPackageManagers: SupportedPackageManagers = { | |||
| cacheFolderCommandList: ['go env GOMODCACHE', 'go env GOCACHE'] | |||
| } | |||
| }; | |||
|
|
|||
| export const getCurrentPackageManager = (): string => 'default'; | |||
There was a problem hiding this comment.
Suggested change
| export const getCurrentPackageManager = (): string => 'default'; | |
| export const getDefaultPackageManager = (): string => 'default'; |
| @@ -14,7 +14,7 @@ inputs: | |||
| default: ${{ github.server_url == 'https://github.com' && github.token || '' }} | |||
| cache: | |||
| description: Used to specify whether caching is needed. Set to true, if you'd like to enable caching. | |||
| default: false | |||
| required: false | |||
There was a problem hiding this comment.
Suggested change
| required: false | |
| default: true | |
| required: false |
| @@ -73,3 +78,16 @@ export function isCacheFeatureAvailable(): boolean { | |||
| ); | |||
| return false; | |||
| } | |||
|
|
|||
| export async function isCacheEnabled() { | |||
There was a problem hiding this comment.
We might split it into two functions:
isCacheEnabled and isCachePathsExists
|
The PR is aborted due to #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change default value for
cacheinputRelated issue:
Add link to the related issue.
Check list: