Allow json comments #431
Merged
Allow json comments #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MaksimZhukov
approved these changes
Jun 5, 2023
IvanZosimov
approved these changes
Jun 6, 2023
dmitry-shibanov
approved these changes
Jun 6, 2023
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changed parsing process of the global.json to use JSON5 library. This should make possible comments in global.json file. Initial approach was to refactor setup-dotnet.ts and pass global.json file directly to the install script instead of parsing it ourselves. However, bash install script doesn't parse JSON properly and throws an error when encounters completely valid JSON like this:
{"sdk":{"version": "2.2.207","rollForward": "latestFeature"}}. Because of that we can't rely on install script to parse JSON and have to do it ourselves with third party library that supports comments in JSON files.Related issue:
#411
Check list: