Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept absolute paths for 'global-json-file' input #396

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Accept absolute paths for 'global-json-file' input #396

merged 2 commits into from
Mar 13, 2023

Conversation

othmane-kinane-nw
Copy link
Contributor

Description:
Use path.resolve instead of path.join to handle absolute paths correctly

Related issue:
fixes #378

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@othmane-kinane-nw othmane-kinane-nw requested a review from a team as a code owner March 10, 2023 23:56
@othmane-kinane-nw othmane-kinane-nw mentioned this pull request Mar 10, 2023
Closed
5 tasks
@dmitry-shibanov dmitry-shibanov merged commit 1d9f0da into actions:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

@panticmilos panticmilos panticmilos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global-json-file input does not accept absolute paths
4 participants
@othmane-kinane-nw @dmitry-shibanov @marko-zivic-93 @panticmilos