Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xunit from 2.4.1 to 2.7.1 in /src #3242

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 12, 2024

Bumps xunit from 2.4.1 to 2.7.1.

Commits
  • 62d5db6 v2.7.1
  • e3c980f #2913: Assert.Equivalent behaves incorrectly with decimal values (v2)
  • 57af1d9 Copy/paste error
  • 9f97a28 #2503: Attempt to shield against exceptions which throw in their properties (v2)
  • f69013b #2903: Add ArgumentFormatter aliases for nint and nuint (v2)
  • e074b6a Copy missing assertion test change
  • 3f1891d Unit tests for #2900 (v2)
  • 9f7e7e7 Use separate projects for x86 builds instead of alternate configuration
  • 4b2b9fa Add hidden overloads for binary compatibility for ConfigReader and friends
  • c10b7a2 Fix for #2892: Timeout async guard inappropriately triggers with F# (v2)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner April 12, 2024 05:07
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Apr 12, 2024
Bumps [xunit](https://github.com/xunit/xunit) from 2.4.1 to 2.7.1.
- [Commits](xunit/xunit@2.4.1...2.7.1)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/src/main/xunit-2.7.1 branch from 14cf5e4 to 06aa0b5 Compare April 15, 2024 02:49
@pje
Copy link
Member

pje commented May 14, 2024

We got a lot of new—and astonishingly pedantic—xunit style violations after upgrading to v2.7.1, which I did my best to fix.

/home/runner/work/runner/runner/src/Test/L0/ProcessExtensionL0.cs(61,21): error xUnit2020: Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/RunnerL0.cs(129,21): error xUnit2020: Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/RunnerL0.cs(309,40): error xUnit1031: Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/RunnerL0.cs(409,40): error xUnit1031: Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/Configuration/ConfigurationManagerL0.cs(193,17): error xUnit2010: Do not use Assert.True() to check for string equality. Use Assert.Equal instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/Configuration/ConfigurationManagerL0.cs(194,17): error xUnit2010: Do not use Assert.True() to check for string equality. Use Assert.Equal instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/Configuration/ConfigurationManagerL0.cs(196,17): error xUnit2010: Do not use Assert.True() to check for string equality. Use Assert.Equal instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/Configuration/ConfigurationManagerL0.cs(295,17): error xUnit2010: Do not use Assert.True() to check for string equality. Use Assert.Equal instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/Configuration/ConfigurationManagerL0.cs(296,17): error xUnit2010: Do not use Assert.True() to check for string equality. Use Assert.Equal instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/Configuration/ConfigurationManagerL0.cs(298,17): error xUnit2010: Do not use Assert.True() to check for string equality. Use Assert.Equal instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/RunnerL0.cs(495,40): error xUnit1031: Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
/home/runner/work/runner/runner/src/Test/L0/Listener/JobDispatcherL0.cs(737,68): error xUnit1031: Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. [/home/runner/work/runner/runner/src/Test/Test.csproj] [/home/runner/work/runner/runner/src/dir.proj]
      0 Warning(s)
      12 Error(s)

@pje
Copy link
Member

pje commented May 14, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Copy link
Contributor Author

dependabot bot commented on behalf of github May 15, 2024

A newer version of xunit exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant