Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always reinstall pip #271

Merged
merged 2 commits into from May 9, 2024
Merged

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 8, 2024

If the default pip version is also the latest one, then the pip executable will be missing as the default pip is installed only as pip3/pip3.x.

In order to always provide a pip executable, always reinstall pip.

This also changes the default built version to 3.12.3 in the build workflow.

@HarithaVattikuti, this shall fix the issues you're seeing on the manual builds.

mayeut added 2 commits May 8, 2024 18:33
If the default pip version is also the latest one,
then the `pip` executable will be missing as the default pip
is installed only as `pip3`/`pip3.x`.

In order to always provide a `pip` executable, always reinstall pip.
Default to the latest stable version.
@mayeut mayeut requested a review from a team as a code owner May 8, 2024 16:46
Copy link
Contributor

@HarithaVattikuti HarithaVattikuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mayeut for the PR

@HarithaVattikuti HarithaVattikuti merged commit 37e7166 into actions:main May 9, 2024
20 checks passed
@mayeut mayeut deleted the default-pip-install branch May 9, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants