Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action outputs #586

Closed
wants to merge 1 commit into from
Closed

add action outputs #586

wants to merge 1 commit into from

Conversation

caioaao
Copy link

@caioaao caioaao commented Jun 13, 2023

Description:
Add two outputs to the action: labels and removed-labels.

Related issue:
Closes #408 (previous PR that didn't include labels-to-remove)
Closes #60

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@caioaao caioaao requested a review from a team as a code owner June 13, 2023 14:15
@MaksimZhukov
Copy link
Contributor

Hello @caioaao ! Thank you for the PR!
We are going to accept #60. It adds the all-labels output which is very useful because the github context contains a set of labels that are only available at the time the event is triggered, changes made during the workflow run won't show up there.
Could you please describe a use case for the removed-labels output?

@caioaao
Copy link
Author

caioaao commented Jun 19, 2023

Hi @MaksimZhukov ! Sounds good. I didn't have any specific use-case in mind, just added it for completeness sake and I think having the all-labels output already fulfills my needs too :) . Since the other PR seems to be moving forward, I'll close this one. Thanks! 👋

@caioaao caioaao closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants