Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Error message for missing config file #475

Merged

Conversation

Gornoka
Copy link
Contributor

@Gornoka Gornoka commented Dec 30, 2022

Description:
Changed error message for missing/misconfigured/misnamed config file.

Related issue:
this should help people to identify this issue quickly
Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@AndreiLobanovich AndreiLobanovich self-requested a review June 28, 2023 15:45
@AndreiLobanovich AndreiLobanovich self-assigned this Jun 28, 2023
Copy link
Contributor

@AndreiLobanovich AndreiLobanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Gornoka!
Thank you for your contribution!
Please, resolve conflicts and consider proposed change. Then we will be happy to merge your PR.

src/labeler.ts Outdated Show resolved Hide resolved
@Gornoka Gornoka closed this Jun 28, 2023
@Gornoka Gornoka force-pushed the error_message_for_missing_conf_rebase branch 2 times, most recently from cc660a6 to 375538a Compare June 28, 2023 20:50
@Gornoka
Copy link
Contributor Author

Gornoka commented Jun 28, 2023

thanks for the feedback, i messed up with the webui a little, pr will be open again soon

@Gornoka Gornoka reopened this Jun 28, 2023
@Gornoka Gornoka requested a review from a team as a code owner June 28, 2023 21:28
package-lock.json Outdated Show resolved Hide resolved
@MaksimZhukov MaksimZhukov merged commit e3c0d9b into actions:main Jun 30, 2023
7 checks passed
@MaksimZhukov
Copy link
Contributor

@Gornoka thank you for the contribution!

@Gornoka Gornoka deleted the error_message_for_missing_conf_rebase branch June 30, 2023 11:45
github-merge-queue bot pushed a commit to owntracks/android that referenced this pull request Jul 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/labeler](https://togithub.com/actions/labeler) | action |
minor | `v4.2.0` -> `v4.3.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs
for more information.

---

### Release Notes

<details>
<summary>actions/labeler (actions/labeler)</summary>

### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0)

#### What's Changed

In scope of this release, the ability to specify pull request number(s)
was added by [@&#8203;credfeto](https://togithub.com/credfeto) in
[actions/labeler#349.

Support for reading from the configuration file presented on the runner
was added by [@&#8203;lrstanley](https://togithub.com/lrstanley) in
[actions/labeler#394.
It allows you to use a configuration file generated during workflow run
or uploaded from a separate repository.

Please refer to the [action
documentation](https://togithub.com/actions/labeler#inputs) for more
information.

This release also includes the following changes:

- Improved Error message for missing config file by
[@&#8203;Gornoka](https://togithub.com/Gornoka) in
[actions/labeler#475
- Early exit when no files are changed by
[@&#8203;nathanhammond](https://togithub.com/nathanhammond) in
[actions/labeler#456
- Add examples to match all repo files by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#600
- Fix a typo in the example about using the action outputs by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#606
- Bump eslint from 8.43.0 to 8.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#601
- Bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.60.1 to 5.61.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#602
- Bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.60.1 to 5.61.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#604
- Bump tough-cookie from 4.1.2 to 4.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#609
- Bump
[@&#8203;octokit/plugin-retry](https://togithub.com/octokit/plugin-retry)
from 5.0.4 to 5.0.5 by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#610

#### New Contributors

- [@&#8203;credfeto](https://togithub.com/credfeto) made their first
contribution in
[actions/labeler#349
- [@&#8203;lrstanley](https://togithub.com/lrstanley) made their first
contribution in
[actions/labeler#394
- [@&#8203;nathanhammond](https://togithub.com/nathanhammond) made their
first contribution in
[actions/labeler#456

**Full Changelog**:
actions/labeler@v4...v4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/owntracks/android).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to owntracks/android that referenced this pull request Jul 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/labeler](https://togithub.com/actions/labeler) | action |
minor | `v4.2.0` -> `v4.3.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs
for more information.

---

### Release Notes

<details>
<summary>actions/labeler (actions/labeler)</summary>

### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0)

#### What's Changed

In scope of this release, the ability to specify pull request number(s)
was added by [@&#8203;credfeto](https://togithub.com/credfeto) in
[actions/labeler#349.

Support for reading from the configuration file presented on the runner
was added by [@&#8203;lrstanley](https://togithub.com/lrstanley) in
[actions/labeler#394.
It allows you to use a configuration file generated during workflow run
or uploaded from a separate repository.

Please refer to the [action
documentation](https://togithub.com/actions/labeler#inputs) for more
information.

This release also includes the following changes:

- Improved Error message for missing config file by
[@&#8203;Gornoka](https://togithub.com/Gornoka) in
[actions/labeler#475
- Early exit when no files are changed by
[@&#8203;nathanhammond](https://togithub.com/nathanhammond) in
[actions/labeler#456
- Add examples to match all repo files by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#600
- Fix a typo in the example about using the action outputs by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#606
- Bump eslint from 8.43.0 to 8.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#601
- Bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.60.1 to 5.61.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#602
- Bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.60.1 to 5.61.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#604
- Bump tough-cookie from 4.1.2 to 4.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#609
- Bump
[@&#8203;octokit/plugin-retry](https://togithub.com/octokit/plugin-retry)
from 5.0.4 to 5.0.5 by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#610

#### New Contributors

- [@&#8203;credfeto](https://togithub.com/credfeto) made their first
contribution in
[actions/labeler#349
- [@&#8203;lrstanley](https://togithub.com/lrstanley) made their first
contribution in
[actions/labeler#394
- [@&#8203;nathanhammond](https://togithub.com/nathanhammond) made their
first contribution in
[actions/labeler#456

**Full Changelog**:
actions/labeler@v4...v4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/owntracks/android).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
flookapa pushed a commit to flookapa/owntracks_android that referenced this pull request Aug 27, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/labeler](https://togithub.com/actions/labeler) | action |
minor | `v4.2.0` -> `v4.3.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs
for more information.

---

### Release Notes

<details>
<summary>actions/labeler (actions/labeler)</summary>

### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0)

#### What's Changed

In scope of this release, the ability to specify pull request number(s)
was added by [@&#8203;credfeto](https://togithub.com/credfeto) in
[actions/labeler#349.

Support for reading from the configuration file presented on the runner
was added by [@&#8203;lrstanley](https://togithub.com/lrstanley) in
[actions/labeler#394.
It allows you to use a configuration file generated during workflow run
or uploaded from a separate repository.

Please refer to the [action
documentation](https://togithub.com/actions/labeler#inputs) for more
information.

This release also includes the following changes:

- Improved Error message for missing config file by
[@&#8203;Gornoka](https://togithub.com/Gornoka) in
[actions/labeler#475
- Early exit when no files are changed by
[@&#8203;nathanhammond](https://togithub.com/nathanhammond) in
[actions/labeler#456
- Add examples to match all repo files by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#600
- Fix a typo in the example about using the action outputs by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#606
- Bump eslint from 8.43.0 to 8.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#601
- Bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.60.1 to 5.61.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#602
- Bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.60.1 to 5.61.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#604
- Bump tough-cookie from 4.1.2 to 4.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/labeler#609
- Bump
[@&#8203;octokit/plugin-retry](https://togithub.com/octokit/plugin-retry)
from 5.0.4 to 5.0.5 by
[@&#8203;MaksimZhukov](https://togithub.com/MaksimZhukov) in
[actions/labeler#610

#### New Contributors

- [@&#8203;credfeto](https://togithub.com/credfeto) made their first
contribution in
[actions/labeler#349
- [@&#8203;lrstanley](https://togithub.com/lrstanley) made their first
contribution in
[actions/labeler#394
- [@&#8203;nathanhammond](https://togithub.com/nathanhammond) made their
first contribution in
[actions/labeler#456

**Full Changelog**:
actions/labeler@v4...v4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/owntracks/android).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants