Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to github.token #199

Closed
wants to merge 2 commits into from
Closed

Default to github.token #199

wants to merge 2 commits into from

Conversation

nuhkoca
Copy link

@nuhkoca nuhkoca commented Aug 3, 2021

To simplify the action, we can add the github.token in the default field for the repo-token input. This would make the action a bit less verbose for normal use. Now the action will default to github.token without needing an explicit definition.

Note: I don't know how to test this properly so that it'd be good if you can test whether or not it works as expected.

@nuhkoca nuhkoca requested a review from a team as a code owner August 3, 2021 23:41
@nuhkoca nuhkoca changed the title Default to github.token by default Default to github.token Aug 3, 2021
@@ -98,19 +98,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@v3
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required anymore

@MichaelDeBoey
Copy link
Contributor

Duplicate of #227

@MaksimZhukov
Copy link
Contributor

Hello @nuhkoca! Thank you for the contribution!
We have already merged these changes (#227)and published new release (v4.0.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants