Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labeler is syncing labels when sync-labels property is false #104

Closed
joncolas opened this issue Oct 1, 2020 · 2 comments
Closed

Labeler is syncing labels when sync-labels property is false #104

joncolas opened this issue Oct 1, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@joncolas
Copy link

joncolas commented Oct 1, 2020

Having created a branch with an empty commit, I create a PR with some tags added manually, then labeler github action is executed and removes (synchronize) all labels that I have defined in the file labeler.yml complying with the file rules.

I tried with sync-labels unset and set to false.

github action log:

Run actions/labeler@main
  with:
    repo-token: ***
    sync-labels: false
    configuration-path: .github/labeler.yml

image

I think this should not happen with the sync-labels set to false, any advice?
@stevecotton stevecotton mentioned this issue Oct 12, 2020
Merged
stevecotton added a commit to wesnoth/wesnoth that referenced this issue Oct 12, 2020
@stevecotton
Stop the labeler removing labels
958c82d 
The sync-labels option was expected to accept "true" or "false" with "false"
being the default.  However, these are currently being converted to boolean
using the Ecmascript `!` operator, which converts both of those strings to
True.  Pass the empty string instead to get the value False.

actions/labeler#104
@Holzhaus
Copy link

I can reproduce it. I'll try to mitigate the issue using the workaround from wesnoth/wesnoth@958c82d.

@epuertat epuertat mentioned this issue Nov 18, 2020
Merged
3 tasks
epuertat added a commit to epuertat/labeler that referenced this issue Nov 18, 2020
@epuertat
Fix 'sync-labels' setting
3695372 
Closes actions#104 

Following syntax at https://github.com/actions/toolkit/blob/master/packages/glob/README.md#recommended-action-inputs
epuertat added a commit to epuertat/labeler that referenced this issue Nov 18, 2020
@epuertat
Fix 'sync-labels' setting
6f2d6a6 
Closes actions#104 

Following syntax at https://github.com/actions/toolkit/blob/master/packages/glob/README.md#recommended-action-inputs
@epuertat epuertat mentioned this issue Nov 18, 2020
Closed
@sungam3r sungam3r mentioned this issue Dec 21, 2020
Merged
@jakemulley jakemulley mentioned this issue Feb 5, 2021
Merged
@Jackenmen Jackenmen mentioned this issue Feb 23, 2021
Merged
3 tasks
anonymouse64 added a commit to anonymouse64/snapd that referenced this issue Feb 23, 2021
@anonymouse64
.github/workflows/labeler.yaml: try work-around to not sync labels
8fd00f4 
This was suggested in the upstream bug at actions/labeler#104

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 mentioned this issue Feb 23, 2021
Merged
anonymouse64 added a commit to anonymouse64/snapd that referenced this issue Feb 24, 2021
@anonymouse64
.github: re-enable auto labeler action to try workaround
8fdbd9e 
This was suggested in the upstream bug at actions/labeler#104

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64 added a commit to snapcore/snapd that referenced this issue Feb 26, 2021
@anonymouse64
Merge pull request #9955 from anonymouse64/bugfix/try-labeler-again
8a92e3e 
.github/workflows/labeler.yaml: try work-around to not sync labels

This was suggested in the upstream bug at actions/labeler#104

Also apply the YAML linter that my editor applies to every YAML file :-)
@gileswells gileswells mentioned this issue Mar 23, 2022
Merged
6 tasks
@MaksimZhukov
Copy link
Contributor

Hello everyone!
I am closing this issue as a duplicate of this one. Please monitor the bug status in scope of that issue.

@MaksimZhukov MaksimZhukov added the duplicate This issue or pull request already exists label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 'sync-labels' setting epuertat/labeler
3 participants
@Holzhaus @joncolas @MaksimZhukov