Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Fix API URL on GHES #437

Closed
wants to merge 11 commits into from
Closed

Draft: Fix API URL on GHES #437

wants to merge 11 commits into from

Conversation

joshmgross
Copy link
Member

@joshmgross joshmgross commented Nov 16, 2023 •
edited

#436

Attempting to reproduce the issue described in #436, and then I will push a change to actually fix it.

- Validating base-url not set respects GITHUB_API_URL
Error: ❌ Expected base-url to equal 'https://my.github-enterprise-server.com/api/v3/', got https://api.github.com/
Error: Process completed with exit code 1.

https://github.com/actions/github-script/actions/runs/6893610162/job/18753569096?pr=437

@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:16 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited

Hello from actions/github-script! (9a202b7)

@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:20 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:24 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:26 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:28 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:33 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:37 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:38 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:43 — with GitHub Actions Inactive
@joshmgross joshmgross mentioned this pull request Nov 16, 2023
Closed
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 23:49 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 23:51 — with GitHub Actions Inactive
@joshmgross joshmgross changed the title Draft: Fix base-url overriding GITHUB_API_URL Draft: Fix API URL on GHES Nov 16, 2023
@joshmgross joshmgross temporarily deployed to debug-integration-test November 17, 2023 15:20 — with GitHub Actions Inactive
@joshmgross joshmgross mentioned this pull request Nov 17, 2023
Merged
@joshmgross
Copy link
Member Author

#439 is shipping this fix and removing the failing integration test, we were able to confirm it works in #436

@joshmgross joshmgross closed this Nov 17, 2023
@joshmgross joshmgross deleted the joshmgross/fix-base-url branch November 17, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joshmgross